Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pull request #5

Open
wants to merge 5 commits into
base: spark2
Choose a base branch
from
Open

pull request #5

wants to merge 5 commits into from

Conversation

shelltdf
Copy link

pull request

@Synxis
Copy link
Owner

Synxis commented Jan 26, 2021

Thanks for the participation !

As is, this PR cannot be accepted. Please separate it in several PRs:

  • one for your CMake improvements. BTW, there are several things that I don't really like:
    • what is "NIUBI" ?
    • the whole CMake config is currently obsolete, it would be nice to redo it entirely
    • no INSTALL rules, please
  • explain why going from size_t to unsigned int ?
  • changing the demos binaries should be an entire separate commit
  • don't change emit because of Qt. This change will always be refused; instead, please tell Qt not to define emit (and also signal btw)
  • why remove virtual ?

@shelltdf
Copy link
Author

in 32bit system size_t is 32bit. in 64bit system is 64bit. but *.spk file used on 32 and 64bit system.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants