Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(perf) Add continuous profiling support #482

Merged
merged 1 commit into from
Jan 7, 2025
Merged

Conversation

Sobeston
Copy link
Contributor

@Sobeston Sobeston commented Jan 7, 2025

Pretty easy change, should be handy.

Has a good amount of detail, even in ReleaseSafe (thanks @Rexicon226 for suggesting to disable omit_frame_pointer).

If you're using docker desktop + macos, this won't work - the profiler won't be able to find your host's process.

image

(focused in on the gossip verification)

image

(focused further, into bincode)

image

@Sobeston Sobeston requested a review from 0xNineteen January 7, 2025 16:32
@Rexicon226
Copy link
Contributor

Wow, nice! How can I test this out?

@Sobeston
Copy link
Contributor Author

Sobeston commented Jan 7, 2025

Wow, nice! How can I test this out?

Start Sig, e.g.
./zig-out/bin/sig gossip -n testnet 2>&1 | tee -a logs/sig.log
then should be as simple as
[metrics]$ SIG_PID=$(pgrep sig) docker compose up

(I'm not sure how common pgrep is, but there's 1000 ways to do that)

Edit: oh and open Grafana, find the Pyroscope data source, group by service_name, look for "sig".

Copy link
Contributor

@0xNineteen 0xNineteen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

wow awesome :shipit:

@Sobeston Sobeston merged commit 0fb04c6 into main Jan 7, 2025
8 checks passed
@Sobeston Sobeston deleted the sobe/pyroscope branch January 7, 2025 18:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants