Working with Text Search in .NET MAUI PDF Viewer #55
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Deepak1799
requested changes
May 20, 2025
| @@ -0,0 +1,24 @@ | |||
| | |||
There was a problem hiding this comment.
- The sample is in TextSearch folder which is fine.
- We may need to add a folder inside (with folder name based on use case) and add the sample. because in future we may add text search samples inside this folder.
|
|
||
| // Load the PDF document from embedded resources. | ||
| Stream? stream = typeof(MainPage).GetTypeInfo().Assembly.GetManifestResourceStream("TextSearch.Assets.PDF_Succinctly.pdf"); | ||
| PdfViewer.LoadDocument(stream!); |
There was a problem hiding this comment.
Here force not null operator is used. Please check with null as below
if (stream != null)
| } | ||
|
|
||
| // Searches for the specified text asynchronously and stores the result. | ||
| async void SearchText(string text) |
There was a problem hiding this comment.
We may need to handle cancelling text search.
https://help.syncfusion.com/maui/pdf-viewer/text-search#cancelling-search-progress
| // Searches for the specified text asynchronously and stores the result. | ||
| async void SearchText(string text) | ||
| { | ||
| SearchResult = await PdfViewer.SearchTextAsync(text); |
There was a problem hiding this comment.
- We may need to show the search progress to the users. Did we handle it? https://help.syncfusion.com/maui/pdf-viewer/text-search#text-search-progress
- We may need to show the search completion to the users. Did we use any "Search completed', "no matches found" kind of things?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
An example added for Working with Text Search in .NET MAUI PDF Viewer