Conversation
- Paths to cvmfs and lmods softcoded as constructor defaults - refactor repeated code into _sort_versions() - deleted format_versions_list and format_build_output - no longer used and do not belong in the builder - Other small tidying for readability
Use shpc to create the module files instead of generating a template module.lua Building always fetches the tool registry (containers.yaml) to check if the CMVFS version exists. Adds the container hash and tag to the .yaml if needed and shpc will always install using the local registry.
Member
Author
Spike test: Inspecting CVMFS images for aliases during buildUtilising shpc-registry helper scripts to create accurate registries from add_container.py: # Generate guts
cli = ManifestGenerator()
manifests = cli.diff(args.image)
# Assemble aliases
aliases = {}
for path in list(manifests.values())[0]["diff"]["unique_paths"]:
# Don't include system bin
if "sbin" in path or "/usr/bin" in path:
print(f"Skipping system bin {path}")
continue
name = os.path.basename(path)
if name in aliases:
print(f"Warning, duplicate alias {name}")
aliases[name] = path
container["aliases"] = aliases
print(f"Writing with aliases to {container_yaml}")
shpc.utils.write_yaml(container, container_yaml)
print(f"container_yaml={container_yaml} >> $GITHUB_OUTPUT")container_guts.main.ManifestGenerator() looks likes the way the shpc workflow automatically updates the aliases, but uses Docker so this is a no go for the BioShell environment Using module load star-fusion
star-fusion-exec find /usr/local/bin -perm +111 -maxdepth 1 | wc -l146 # MANY binaries...Can we diff out the utility tools (e.g. non bioinformatics binaries) from /usr/bin? star-fusion-exec find /usr/bin -perm +111 -maxdepth 1 | head/usr/bin/[
/usr/bin/[[
/usr/bin/ar
/usr/bin/awk
/usr/bin/basename
/usr/bin/bunzip2
/usr/bin/bzcat
/usr/bin/chrt
/usr/bin/chvtSTAR-fusion v1.0.0 conda build script: Resource for biocontainer builds: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR makes shelley 🐢 build modules using
shpc installunder the hood, replacing creating a dummymodules.luafile.Manual tests
blast:2.5.0--hc0b0e79_3Notes:
star/2.7.11a--h0033a41_0
star-fusion:1.0.0Confirmed: registry aliases does not reflect older versions.
Possible solution is to use an automated binary detection like shpc-guts that is compatible with singularity?