ci: migrate staging secrets to GitHub Environment#1768
Merged
Conversation
Adds `environment: Staging` to the deploy job and removes all `STAGING_` prefixes from secrets and variables, relying on environment-level scoping instead of naming conventions. Also updates docs/CI-CD/workflows.md to document the split between repository-level secrets (DockerHub) and Staging environment secrets. Closes #1767 Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
tyler-dane
force-pushed
the
ci/migrate-staging-secrets-to-environment
branch
from
b798d85 to
5374581
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
environment: Stagingto the deploy job indeploy-staging.ymlSTAGING_prefixes from 8 secrets and 5 variables — environment scoping replaces the naming conventiondocs/CI-CD/workflows.mdto document the repository-level vs environment-level secret splitPre-merge validation
Before merging, manually trigger the
Deploy stagingworkflow from this branch to confirm secrets resolve correctly:ci/migrate-staging-secrets-to-environment./compass updateruns)Post-merge cleanup
Once the deploy is confirmed working, delete the old
STAGING_-prefixed secrets and variables from repository-level Actions secrets.Closes #1767