Issue 3469 dependency transition 14 #3575
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
finestructure
commented
Jan 1, 2025
| @@ -19,7 +19,7 @@ import PackageDescription | |||
| let package = Package( | |||
| name: "SPI-Server", | |||
| platforms: [ | |||
| .macOS(.v13) | |||
| .macOS(.v15) | |||
There was a problem hiding this comment.
macOS 15 is required for typed throw runtime support due to our use of
@Dependency(\.github.fetchMetadata) var fetchMetadata
below.
finestructure
commented
Jan 1, 2025
| guard case Github.Error.requestFailed(.badRequest) = error else { | ||
| XCTFail("unexpected error: \(error.localizedDescription)") | ||
| return | ||
| } | ||
| } | ||
| } | ||
| } |
There was a problem hiding this comment.
This test is now superfluous. It tested the parseOwnerName part of the static func fetchMetadata(client: Client, packageUrl: String) async throws → Metadata overload that was actually not used and which I removed.
finestructure
force-pushed
the
issue-3469-dependency-transition-14
branch
from
85201b5 to
d1f9586
Compare
daveverwer
approved these changes
Jan 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This moves
fetchMetadatatoGithubClient.