script for one click start in ubuntu#221
Open
patelfenil wants to merge 1 commit intoSwellRT:masterfrom
Open
Conversation
Contributor
|
Cool! I will review it today!
Thanks a lot
2017-06-26 22:23 GMT+02:00 Fenil Patel <notifications@github.com>:
… This script provides one click start type functionality.
On running the script
1. if docker is not installed then docker will be installed
2. all the commands for starting up swellrt will be executed
After the completion of the script, the user can checkout swellrt on
localhost:9898.
------------------------------
You can view, comment on, or merge this pull request online at:
https://github.com/P2Pvalue/swellrt/pull/221
Commit Summary
- script for one click start in ubuntu
File Changes
- *A* scripts/ubuntu_script
<https://github.com/P2Pvalue/swellrt/pull/221/files#diff-0> (46)
Patch Links:
- https://github.com/P2Pvalue/swellrt/pull/221.patch
- https://github.com/P2Pvalue/swellrt/pull/221.diff
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
<https://github.com/P2Pvalue/swellrt/pull/221>, or mute the thread
<https://github.com/notifications/unsubscribe-auth/AEP6D1aHnz3S4rPLFOpHxJ9op4HxcoVjks5sIBNagaJpZM4OFzwQ>
.
|
pablojan
reviewed
Jun 28, 2017
Contributor
pablojan
left a comment
There was a problem hiding this comment.
Thanks for the work. Which tests have you run?
I see multiple lines starting the swellrt container "docker run (...) p2pvalue/swellrt " but I think there should be just one, having multiple arguments -v and -e
Contributor
|
More comments:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This script provides one click start type functionality.
On running the script
After the completion of the script, the user can checkout swellrt on localhost:9898.