Quit child processes when supervisor crashes (Linux only) #649
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use prctl(PR_SET_PDEATHSIG, SIGTERM) to send signal when parent dies
|
This is so close to #199 that I'm going to close it as a duplicate with a link back here. |
|
@mnaberez - As far as I know this patch is done. |
|
Ready for further review or merge. |
|
Note for future review: also credit Scott Wilson (#199) in changelog if this is merged. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm just adding a check around only calling the code on a linux box and adding a constant so it's a little more clear. Would be cool to get this one finally out of the pull requests backlog.
Original pull request: #199