This repository was archived by the owner on Dec 23, 2025. It is now read-only.
Issue #KN-231 chore: Added the default value for aws and gcloud. #1780
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vinukumar-vs
suggested changes
Sep 22, 2022
| learning_service.basePath = "{{ kp_learning_service_base_url }}" | ||
| } | ||
|
|
||
| #Cloud storage config |
Contributor
There was a problem hiding this comment.
Duplicate entry. This is already defined on top line 552
| aws_storage_container= "{{ aws_storage_container_name }}" | ||
|
|
||
| #Google cloud config | ||
| gcloud_client_key: "{{ sunbird_gcloud_client_key }}" |
Contributor
There was a problem hiding this comment.
Same keys are duplicated multiple times. Check all CSP configuration properties once.
Contributor
vinukumar-vs
left a comment
vinukumar-vs
left a comment
There was a problem hiding this comment.
Check this way,
Create a separate CSP config file and import for which ever jobs we need
include file("/data/flink/conf/base-config.conf")
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.