-
Notifications
You must be signed in to change notification settings - Fork 171
feat: Migrate to Play Framework 3.0.5, Apache Pekko 1.0.3, and Scala 2.13.12 #1123
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Migrate to Play Framework 3.0.5, Apache Pekko 1.0.3, and Scala 2.13.12 #1123
Conversation
…ade Play to 3.0.5 Co-authored-by: chethann007 <[email protected]>
…CollectionConverters Co-authored-by: chethann007 <[email protected]>
Co-authored-by: chethann007 <[email protected]>
….3 with Play Framework 3.0.5 - Upgrade from Akka 2.5.22 to Apache Pekko 1.0.3 across all services - Migrate from Play Framework 2.7.x/2.8.x to Play Framework 3.0.5 - Upgrade Scala from 2.12.11 to 2.13.12 with collections compatibility fixes - Update Guice from 4.2.3 to 7.0.0 and align all dependency injection patterns - Standardize Netty version to 4.1.112.Final across content, search, and taxonomy services - Fix Scala 2.13 collections immutability issues in UpdateHierarchyManager - Update actor binding syntax from bind(classOf[Actor]) to bindActor[Actor]() for Play 3.0.5 - Add missing LockActor binding in TaxonomyModule for lock management functionality - Resolve dependency conflicts for Guava, Jackson, and other transitive dependencies - Update logging configuration to use SLF4J/Logback consistently
Migrate to Play Framework 3.0.5, Apache Pekko 1.0.3, and Scala 2.13.12
…ala 2.13 compatibility and improve error handling
…holders for better configurability
Migrate to Play Framework 3.0.5, Apache Pekko 1.0.3, and Scala 2.13.12
…ap, add .asJava conversions Co-authored-by: chethann007 <[email protected]>
…essorTest.java Co-authored-by: chethann007 <[email protected]>
…ests Fix Scala test compilation errors: HashMap instantiation and Java Map conversions
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the ✨ Finishing touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This pull request performs a comprehensive migration of the codebase from Akka to Apache Pekko, Scala 2.12 to 2.13, and Play Framework 2.x to 3.x. This is a major framework upgrade necessitated by Akka's license change.
Key Changes:
- Migration from Akka to Apache Pekko (all actor and pattern imports updated)
- Scala version upgrade from 2.12 to 2.13
- Play Framework upgrade from 2.7.x/2.8.x to 3.0.5
- Java collection converters migration from
JavaConverterstojdk.CollectionConverters - Test framework updates and async test pattern changes
- Configuration updates replacing
akkareferences withpekko
Reviewed Changes
Copilot reviewed 212 out of 249 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| taxonomy-service-sbt/build.sbt | Updated Scala version to 2.13.12 and Play dependencies to 3.0.5 |
| taxonomy-service-sbt/project/plugins.sbt | Updated Play sbt plugin to 3.0.5 |
| taxonomy-service-sbt/conf/routes | Added parentheses to controller method calls for Play 3.x compatibility |
| taxonomy-service-sbt/conf/application.conf | Updated config keys from akka to pekko |
| taxonomy-api/taxonomy-service/pom.xml | Updated Play dependencies to 3.0.5, added Netty BOM for dependency management |
| taxonomy-api/taxonomy-service/app/modules/TaxonomyModule.scala | Updated to PekkoGuiceSupport and new bindActor syntax |
| taxonomy-api/taxonomy-service/app/handlers/SignalHandler.scala | Updated imports to Pekko, fixed scheduler syntax |
| taxonomy-api/taxonomy-service/app/filters/AccessLogFilter.scala | Updated to use scala.jdk.CollectionConverters and view.mapValues |
| taxonomy-api/taxonomy-actors/pom.xml | Updated dependencies to use Pekko and Scala 2.13 |
| search-api/search-core/src/test/java/org/sunbird/search/SearchProcessorTest.java | Refactored async tests to use Await.result instead of onSuccess callbacks |
| platform-core/actor-core/pom.xml | Updated to Pekko dependencies |
| ontology-engine/graph-engine_2.13/src/main/scala | New Scala 2.13 module with updated collection converters |
| pom.xml | Updated root Scala version to 2.13.12 and Jackson to 2.15.3 |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
Copilot reviewed 212 out of 249 changed files in this pull request and generated no new comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
906f932
into
Sunbird-Knowlg:release-8.1.0
Summary
This pull request introduces a major migration from Akka to Apache Pekko across the codebase, along with improvements for Scala 2.13 compatibility in handling Scala Maps within Java code. The most significant changes include updating dependencies, refactoring imports, enhancing the handling of Scala collections.