Skip to content

#SBCOSS-452 Updated the Code-Quality-check workflow for search service. #1109

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
pallakartheekreddy merged 2 commits into from
Jun 9, 2025
Merged

#SBCOSS-452 Updated the Code-Quality-check workflow for search service. #1109

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4a43f74
Updated the C0de-Quality-check workflow for search service.
vinodbhorge Jun 9, 2025
7415e78
Updated the changes recommended by copilot.
vinodbhorge Jun 9, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
79 changes: 76 additions & 3 deletions .github/workflows/Code-Quality-check.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -120,6 +120,42 @@ jobs:
reporter: java-junit
fail-on-error: true

test-search:
needs: build
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v3
- name: Set up JDK 11
uses: actions/setup-java@v3
with:
java-version: '11'
distribution: 'temurin'
cache: 'maven'

- name: Run Search Tests
working-directory: search-api/search-service/
Copy link

Copilot AI Jun 9, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[nitpick] Trailing slash in working-directory is not needed and differs from other job definitions. Consider removing it for consistency (search-api/search-service).

Suggested change
working-directory: search-api/search-service/
working-directory: search-api/search-service

Copilot uses AI. Check for mistakes.
run: |
mvn clean test org.jacoco:jacoco-maven-plugin:0.8.8:prepare-agent test org.jacoco:jacoco-maven-plugin:0.8.8:report \
Copy link

Copilot AI Jun 9, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The Maven command invokes the test goal twice (before and after the Jacoco prepare-agent). This will run your tests twice and slow down the workflow. Consider using mvn clean org.jacoco:jacoco-maven-plugin:0.8.8:prepare-agent test org.jacoco:jacoco-maven-plugin:0.8.8:report instead.

Suggested change
mvn clean test org.jacoco:jacoco-maven-plugin:0.8.8:prepare-agent test org.jacoco:jacoco-maven-plugin:0.8.8:report \
mvn clean org.jacoco:jacoco-maven-plugin:0.8.8:prepare-agent test org.jacoco:jacoco-maven-plugin:0.8.8:report \

Copilot uses AI. Check for mistakes.
-DCLOUD_STORE_GROUP_ID=${CLOUD_STORE_GROUP_ID} \
-DCLOUD_STORE_ARTIFACT_ID=${CLOUD_STORE_ARTIFACT_ID} \
-DCLOUD_STORE_VERSION=${CLOUD_STORE_VERSION}

- name: Upload Search Test Results
if: always()
uses: actions/upload-artifact@v4
with:
name: search-test-results
path: 'search-api/search-service/target/surefire-reports/*.xml'

- name: Publish Search Test Results
if: always()
uses: dorny/test-reporter@v1
with:
name: Search Test Results
path: search-api/search-service/target/surefire-reports/*.xml
reporter: java-junit
fail-on-error: true

sonar-analysis-content:
needs: test-content
runs-on: ubuntu-latest
Expand Down Expand Up @@ -170,8 +206,43 @@ jobs:
-Dsonar.host.url=https://sonarcloud.io \
-Dsonar.coverage.jacoco.xmlReportPaths=taxonomy-api/taxonomy-service/target/site/jacoco/jacoco.xml

sonar-analysis-search:
needs: test-search
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v3
with:
fetch-depth: 0
- name: Set up JDK 17
uses: actions/setup-java@v3
with:
java-version: '17'
distribution: 'temurin'
cache: 'maven'
- name: Run SonarCloud Analysis for Search
env:
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
SONAR_TOKEN: ${{ secrets.SONAR_TOKEN }}
working-directory: search-api/search-service
run: |
mvn clean compile \
-DCLOUD_STORE_GROUP_ID=${CLOUD_STORE_GROUP_ID} \
-DCLOUD_STORE_ARTIFACT_ID=${CLOUD_STORE_ARTIFACT_ID} \
-DCLOUD_STORE_VERSION=${CLOUD_STORE_VERSION}

mvn sonar:sonar \
-DCLOUD_STORE_GROUP_ID=${CLOUD_STORE_GROUP_ID} \
-DCLOUD_STORE_ARTIFACT_ID=${CLOUD_STORE_ARTIFACT_ID} \
-DCLOUD_STORE_VERSION=${CLOUD_STORE_VERSION} \
-Dsonar.projectKey=Sunbird-Knowlg_knowledge-platform \
-Dsonar.organization=sunbird-knowlg-1 \
-Dsonar.host.url=https://sonarcloud.io \
-Dsonar.java.binaries=target/classes \
-Dsonar.java.test.binaries=target/test-classes \
-Dsonar.coverage.jacoco.xmlReportPaths=search-api/search-service/target/site/jacoco/jacoco.xml

comment-pr:
needs: [sonar-analysis-content, sonar-analysis-taxonomy]
needs: [sonar-analysis-content, sonar-analysis-taxonomy, sonar-analysis-search]
if: github.event_name == 'pull_request'
runs-on: ubuntu-latest
steps:
Expand All @@ -182,7 +253,9 @@ jobs:
const message = `### SonarCloud Analysis Results 🔍

#### Quality Gate Results for Services:
- [Service Analysis](https://sonarcloud.io/dashboard?id=Sunbird-Knowlg_knowledge-platform)
- [Content Service Analysis](https://sonarcloud.io/dashboard?id=Sunbird-Knowlg_knowledge-platform_content)
- [Taxonomy Service Analysis](https://sonarcloud.io/dashboard?id=Sunbird-Knowlg_knowledge-platform_taxonomy)
- [Search Service Analysis](https://sonarcloud.io/dashboard?id=Sunbird-Knowlg_knowledge-platform_search)

Please review the analysis results for each service. Ensure all quality gates are passing before merging.`;

Expand All @@ -191,4 +264,4 @@ jobs:
repo: context.repo.repo,
issue_number: context.issue.number,
body: message
});
});
Loading