Skip to content

#SBCOSS-449 Code quality #1106

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
pallakartheekreddy merged 2 commits into from
Jun 6, 2025

Merge pull request #1105 from vinodbhorge/code-quality

c173821
Select commit
Loading
Failed to load commit list.
Sign in for the full log view
Merged

#SBCOSS-449 Code quality #1106

Merge pull request #1105 from vinodbhorge/code-quality
c173821
Select commit
Loading
Failed to load commit list.
GitHub Actions / Test Results succeeded Jun 6, 2025 in 0s

114 passed, 0 failed and 0 skipped

Tests passed successfully

Report Passed Failed Skipped Time
content-api/content-service/target/surefire-reports/TEST-controllers.v3.BadRequestSpec.xml 1✅ 355ms
content-api/content-service/target/surefire-reports/TEST-controllers.v3.CategorySpec.xml 4✅ 148ms
content-api/content-service/target/surefire-reports/TEST-controllers.v3.ChannelSpec.xml 4✅ 175ms
content-api/content-service/target/surefire-reports/TEST-controllers.v3.ContentSpec.xml 27✅ 393ms
content-api/content-service/target/surefire-reports/TEST-controllers.v3.HealthSpec.xml 1✅ 132ms
content-api/content-service/target/surefire-reports/TEST-controllers.v3.LicenseSpec.xml 4✅ 170ms
content-api/content-service/target/surefire-reports/TEST-controllers.v4.AppSpec.xml 3✅ 180ms
content-api/content-service/target/surefire-reports/TEST-controllers.v4.AssetSpec.xml 11✅ 274ms
content-api/content-service/target/surefire-reports/TEST-controllers.v4.CollectionSpec.xml 22✅ 511ms
content-api/content-service/target/surefire-reports/TEST-controllers.v4.ContentSpec.xml 23✅ 5s
content-api/content-service/target/surefire-reports/TEST-controllers.v4.EventSetSpec.xml 8✅ 281ms
content-api/content-service/target/surefire-reports/TEST-controllers.v4.EventSpec.xml 5✅ 306ms
content-api/content-service/target/surefire-reports/TEST-controllers.v4.ObjectSpec.xml 1✅ 193ms

✅ content-api/content-service/target/surefire-reports/TEST-controllers.v3.BadRequestSpec.xml

1 tests were completed in 355ms with 1 passed, 0 failed and 0 skipped.

Test suite Passed Failed Skipped Time
controllers.v3.BadRequestSpec 1✅ 355ms

✅ controllers.v3.BadRequestSpec

✅ Application should::send 404 on a bad request - /boum

✅ content-api/content-service/target/surefire-reports/TEST-controllers.v3.CategorySpec.xml

4 tests were completed in 148ms with 4 passed, 0 failed and 0 skipped.

Test suite Passed Failed Skipped Time
controllers.v3.CategorySpec 4✅ 148ms

✅ controllers.v3.CategorySpec

✅ Category Controller  should::return success response for create API
✅ Category Controller  should::return success response for update API
✅ Category Controller  should::return success response for read API
✅ Category Controller  should::return success response for retire API

✅ content-api/content-service/target/surefire-reports/TEST-controllers.v3.ChannelSpec.xml

4 tests were completed in 175ms with 4 passed, 0 failed and 0 skipped.

Test suite Passed Failed Skipped Time
controllers.v3.ChannelSpec 4✅ 175ms

✅ controllers.v3.ChannelSpec

✅ Channel Controller  should::return success response for create API
✅ return success response for update API
✅ return success response for read API
✅ return success response for retire API

✅ content-api/content-service/target/surefire-reports/TEST-controllers.v3.ContentSpec.xml

27 tests were completed in 393ms with 27 passed, 0 failed and 0 skipped.

Test suite Passed Failed Skipped Time
controllers.v3.ContentSpec 27✅ 393ms

✅ controllers.v3.ContentSpec

✅ Content Controller  should::return success response for create API
✅ Content Controller  should::return success response for update API
✅ Content Controller  should::return success response for read API
✅ Content Controller  should::return success response for hierarchy add API
✅ Content Controller  should::return success response for hierarchy remove API
✅ Content Controller  should::return success response for hierarchy get API
✅ Content Controller  should::return success response for flag API
✅ Content Controller  should::return success response for acceptFlag API
✅ Content Controller  should::return success response for rejectFlag API
✅ Content Controller  should::return success response for bundle API
✅ Content Controller  should::return success response for publish API
✅ Content Controller  should::return success response for review API
✅ Content Controller  should::return success response for discard API
✅ Content Controller  should::return success response for retire API
✅ Content Controller  should::return success response for linkDialCode API
✅ Content Controller  should::return success response for collectionLinkDialCode API
✅ Content Controller  should::return success response for reserveDialCode API
✅ Content Controller  should::return success response for releaseDialcodes API
✅ Content Controller  should::return success response for publishUnlisted API
✅ Content Controller  should::return success response for presignedUrl upload API
✅ return success response for upload API with file
✅ return success response for upload API with fileUrl
✅ return success response for upload API with fileUrl and fileFormat
✅ return success response for importContent API
✅ return success response for hierarchy update API
✅ return success response for bookmark hierarchy API
✅ return success response for copy API

✅ content-api/content-service/target/surefire-reports/TEST-controllers.v3.HealthSpec.xml

1 tests were completed in 132ms with 1 passed, 0 failed and 0 skipped.

Test suite Passed Failed Skipped Time
controllers.v3.HealthSpec 1✅ 132ms

✅ controllers.v3.HealthSpec

✅ Application should::return api health status report - successful

✅ content-api/content-service/target/surefire-reports/TEST-controllers.v3.LicenseSpec.xml

4 tests were completed in 170ms with 4 passed, 0 failed and 0 skipped.

Test suite Passed Failed Skipped Time
controllers.v3.LicenseSpec 4✅ 170ms

✅ controllers.v3.LicenseSpec

✅ License Controller  should::return success response for create API
✅ License Controller  should::return success response for update API
✅ License Controller  should::return success response for read API
✅ License Controller  should::return success response for retire API

✅ content-api/content-service/target/surefire-reports/TEST-controllers.v4.AppSpec.xml

3 tests were completed in 180ms with 3 passed, 0 failed and 0 skipped.

Test suite Passed Failed Skipped Time
controllers.v4.AppSpec 3✅ 180ms

✅ controllers.v4.AppSpec

✅ AppController  should::return success response for register API
✅ AppController  should::return success response for update API
✅ AppController  should::return success response for read API

✅ content-api/content-service/target/surefire-reports/TEST-controllers.v4.AssetSpec.xml

11 tests were completed in 274ms with 11 passed, 0 failed and 0 skipped.

Test suite Passed Failed Skipped Time
controllers.v4.AssetSpec 11✅ 274ms

✅ controllers.v4.AssetSpec

✅ AssetController  should::return success response for create API
✅ AssetController  should::return success response for update API
✅ AssetController  should::return success response for read API
✅ AssetController  should::return success response for upload API with file
✅ AssetController  should::return success response for upload API with fileUrl
✅ AssetController  should::return success response for upload API with fileUrl and fileFormat
✅ AssetController  should::return success response for pre signed Url upload API
✅ AssetController  should::return success response for copy API
✅ AssetController  should::return success response for licenceValidate API
✅ Asset controller with invalid request  should::return client error response for create API
✅ Asset controller with invalid request  should::return client error response for create API

✅ content-api/content-service/target/surefire-reports/TEST-controllers.v4.CollectionSpec.xml

22 tests were completed in 511ms with 22 passed, 0 failed and 0 skipped.

Test suite Passed Failed Skipped Time
controllers.v4.CollectionSpec 22✅ 511ms

✅ controllers.v4.CollectionSpec

✅ Collection Controller  should::return success response for create API
✅ Collection Controller  should::return success response for update API
✅ Collection Controller  should::return success response for read API
✅ Collection Controller  should::return success response for private read API
✅ Collection Controller  should::return success response for hierarchy add API
✅ Collection Controller  should::return success response for hierarchy remove API
✅ Collection Controller  should::return success response for hierarchy get API
✅ Collection Controller  should::return success response for flag API
✅ Collection Controller  should::return success response for acceptFlag API
✅ Collection Controller  should::return success response for discard API
✅ Collection Controller  should::return success response for retire API
✅ Collection Controller  should::return success response for collectionLinkDialCode API
✅ Collection Controller  should::return success response for collection review reject API
✅ Collection Controller  should::return success response for collection review API
✅ return success response for hierarchy update API
✅ return success response for bookmark hierarchy API
✅ return success response for copy API
✅ Collection Controller with invalid request  should::return client error response for create API
✅ Collection Controller with invalid request  should::return client error response for create API
✅ Collection Controller with valid request  should::return success response for systemUpdate API
✅ Collection Controller with valid request  should::return success response for dialcode reserve API
✅ Collection Controller with valid request  should::return success response for dialcode release API

✅ content-api/content-service/target/surefire-reports/TEST-controllers.v4.ContentSpec.xml

23 tests were completed in 5s with 23 passed, 0 failed and 0 skipped.

Test suite Passed Failed Skipped Time
controllers.v4.ContentSpec 23✅ 5s

✅ controllers.v4.ContentSpec

✅ Content Controller  should::return success response for create API
✅ Content Controller  should::return success response for update API
✅ Content Controller  should::return success response for read API
✅ Content Controller  should::return success response for private read API
✅ Content Controller  should::return success response for flag API
✅ Content Controller  should::return success response for acceptFlag API
✅ Content Controller  should::return success response for discard API
✅ Content Controller  should::return success response for retire API
✅ Content Controller  should::return success response for linkDialCode API
✅ Content Controller  should::return success response for presignedUrl upload API
✅ Content Controller  should::return success response for rejectContent API
✅ Content Controller  should::return success response for review API
✅ Content Controller  should::return success response for reviewReject API
✅ return success response for upload API with file
✅ return success response for upload API with fileUrl
✅ return success response for upload API with fileUrl and fileFormat
✅ return success response for importContent API
✅ return success response for copy API
✅ Content Controller with invalid request  should::return client error response for create API
✅ Content Controller with invalid request  should::return client error response for create API
✅ Content Controller with valid request  should::return success response for systemUpdate API
✅ Content Controller with valid request  should::return success response for dialcode reserve API
✅ Content Controller with valid request  should::return success response for dialcode release API

✅ content-api/content-service/target/surefire-reports/TEST-controllers.v4.EventSetSpec.xml

8 tests were completed in 281ms with 8 passed, 0 failed and 0 skipped.

Test suite Passed Failed Skipped Time
controllers.v4.EventSetSpec 8✅ 281ms

✅ controllers.v4.EventSetSpec

✅ EventSet Controller  should::return success response for create API
✅ EventSet Controller  should::return success response for update API
✅ EventSet Controller  should::return success response for read API
✅ EventSet Controller  should::return success response for hierarchy get API
✅ EventSet Controller  should::return success response for discard API
✅ EventSet Controller  should::return success response for retire API
✅ EventSet Controller  should::return error response when updating status using update API
✅ EventSet Controller  should::return success response for publish API

✅ content-api/content-service/target/surefire-reports/TEST-controllers.v4.EventSpec.xml

5 tests were completed in 306ms with 5 passed, 0 failed and 0 skipped.

Test suite Passed Failed Skipped Time
controllers.v4.EventSpec 5✅ 306ms

✅ controllers.v4.EventSpec

✅ Event Controller  should::return success response for create API
✅ Event Controller  should::return success response for read API
✅ Event Controller  should::return success response for update API
✅ Event Controller  should::return error response when updating status using update API
✅ Event Controller  should::return success response for publish API

✅ content-api/content-service/target/surefire-reports/TEST-controllers.v4.ObjectSpec.xml

1 tests were completed in 193ms with 1 passed, 0 failed and 0 skipped.

Test suite Passed Failed Skipped Time
controllers.v4.ObjectSpec 1✅ 193ms

✅ controllers.v4.ObjectSpec

✅ Object controller should::return success response for read API
View more details on GitHub Actions