Skip to content

🚑 Fix missing mobile navigation auto-close #31

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
loicmaes merged 3 commits into from
Apr 11, 2026
Merged

🚑 Fix missing mobile navigation auto-close #31

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
51e1011
:rocket: add new sheet navigation to handle auto-close behavior
loicmaes Apr 11, 2026
61c0d51
:fire: remove unused import
loicmaes Apr 11, 2026
3f1a9ab
Merge pull request #30 from Studio-Klypi/fix/batch-11042026
loicmaes Apr 11, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .eslintcache
View file
Open in desktop

Large diffs are not rendered by default.

56 changes: 56 additions & 0 deletions app/components/navigation/SheetNavigation.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,56 @@
<script setup lang="ts">
import { LINKS } from "~/components/navigation/index";
import { Menu } from "@lucide/vue";
import Logo from "~/components/brand/Logo.vue";
import LangSwitcher from "~/components/interface/LangSwitcher.vue";
import ThemeSwitcher from "~/components/interface/ThemeSwitcher.vue";

const open = ref<boolean>(false);
</script>

<template>
<UiSheet v-model:open="open">
<UiSheetTrigger as-child>
<UiButton
size="icon"
variant="ghost"
>
<Menu />
</UiButton>
</UiSheetTrigger>
<UiSheetContent
side="right"
class="max-w-xs"
>
<UiSheetHeader class="flex flex-row items-center gap-1">
<Logo class="size-9" />
<p class="font-semibold">
Studio Klypi
</p>
</UiSheetHeader>

<div class="grid gap-0.5 px-4">
<UiButton
v-for="link in LINKS"
:key="link.key"
variant="ghost"
class="justify-start"
as-child
@click="open = false"
>
<NuxtLinkLocale
:to="link.path"
active-class="bg-accent! text-accent-foreground!"
>
{{ $t(`${link.key}.navigation-name`) }}
</NuxtLinkLocale>
</UiButton>
</div>

<UiSheetFooter class="flex-row justify-center">
<ThemeSwitcher />
<LangSwitcher />
</UiSheetFooter>
</UiSheetContent>
</UiSheet>
</template>
90 changes: 3 additions & 87 deletions app/components/navigation/TopBar.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,10 +1,10 @@
<script setup lang="ts">
import { Menu } from "@lucide/vue";
import { LINKS } from "~/components/navigation/index";
import Logo from "~/components/brand/Logo.vue";
import Wrapper from "~/components/composing/Wrapper.vue";
import ThemeSwitcher from "~/components/interface/ThemeSwitcher.vue";
import LangSwitcher from "~/components/interface/LangSwitcher.vue";
import SheetNavigation from "~/components/navigation/SheetNavigation.vue";

const { isMobile } = useResponsive();
</script>
Expand All @@ -23,49 +23,7 @@ const { isMobile } = useResponsive();
</NuxtLinkLocale>

<ClientOnly>
<UiSheet v-if="isMobile">
<UiSheetTrigger as-child>
<UiButton
size="icon"
variant="ghost"
>
<Menu />
</UiButton>
</UiSheetTrigger>
<UiSheetContent
side="right"
class="max-w-xs"
>
<UiSheetHeader class="flex flex-row items-center gap-1">
<Logo class="size-9" />
<p class="font-semibold">
Studio Klypi
</p>
</UiSheetHeader>

<div class="grid gap-0.5 px-4">
<UiButton
v-for="link in LINKS"
:key="link.key"
variant="ghost"
class="justify-start"
as-child
>
<NuxtLinkLocale
:to="link.path"
active-class="bg-accent! text-accent-foreground!"
>
{{ $t(`${link.key}.navigation-name`) }}
</NuxtLinkLocale>
</UiButton>
</div>

<UiSheetFooter class="flex-row justify-center">
<ThemeSwitcher />
<LangSwitcher />
</UiSheetFooter>
</UiSheetContent>
</UiSheet>
<SheetNavigation v-if="isMobile" />
<nav
v-else
class="flex items-center gap-0.5"
Expand All @@ -91,49 +49,7 @@ const { isMobile } = useResponsive();
</nav>

<template #fallback>
<UiSheet>
<UiSheetTrigger as-child>
<UiButton
size="icon"
variant="ghost"
>
<Menu />
</UiButton>
</UiSheetTrigger>
<UiSheetContent
side="right"
class="max-w-xs"
>
<UiSheetHeader class="flex flex-row items-center gap-1">
<Logo class="size-9" />
<p class="font-semibold">
Studio Klypi
</p>
</UiSheetHeader>

<div class="grid gap-0.5 px-4">
<UiButton
v-for="link in LINKS"
:key="link.key"
variant="ghost"
class="justify-start"
as-child
>
<NuxtLinkLocale
:to="link.path"
active-class="bg-accent! text-accent-foreground!"
>
{{ $t(`${link.key}.navigation-name`) }}
</NuxtLinkLocale>
</UiButton>
</div>

<UiSheetFooter class="flex-row justify-center">
<ThemeSwitcher />
<LangSwitcher />
</UiSheetFooter>
</UiSheetContent>
</UiSheet>
<SheetNavigation />
</template>
</ClientOnly>
</Wrapper>
Expand Down