Optimize buffer types

StuckiSimon · Aug 17, 2024 · f00ebfb · f00ebfb
1 parent ffcafb5
commit f00ebfb
Show file tree

Hide file tree

Showing 2 changed files with 16 additions and 16 deletions.
diff --git a/strahl-lib/src/path-tracer.ts b/strahl-lib/src/path-tracer.ts
@@ -507,56 +507,56 @@ async function runPathTracer(
         binding: 0,
         visibility: GPUShaderStage.COMPUTE,
         buffer: {
-          type: "storage",
+          type: "read-only-storage",
         },
       },
       {
         binding: 1,
         visibility: GPUShaderStage.COMPUTE,
         buffer: {
-          type: "storage",
+          type: "read-only-storage",
         },
       },
       {
         binding: 2,
         visibility: GPUShaderStage.COMPUTE,
         buffer: {
-          type: "storage",
+          type: "read-only-storage",
         },
       },
       {
         binding: 3,
         visibility: GPUShaderStage.COMPUTE,
         buffer: {
-          type: "storage",
+          type: "read-only-storage",
         },
       },
       {
         binding: 4,
         visibility: GPUShaderStage.COMPUTE,
         buffer: {
-          type: "storage",
+          type: "read-only-storage",
         },
       },
       {
         binding: 5,
         visibility: GPUShaderStage.COMPUTE,
         buffer: {
-          type: "storage",
+          type: "read-only-storage",
         },
       },
       {
         binding: 6,
         visibility: GPUShaderStage.COMPUTE,
         buffer: {
-          type: "storage",
+          type: "read-only-storage",
         },
       },
       {
         binding: 7,
         visibility: GPUShaderStage.COMPUTE,
         buffer: {
-          type: "storage",
+          type: "read-only-storage",
         },
       },
     ],

diff --git a/strahl-lib/src/tracer-shader.wgsl b/strahl-lib/src/tracer-shader.wgsl
@@ -59,20 +59,20 @@ struct VertexPackage {
 }
 
 // CODE#BUFFER-BINDINGS
-@group(0) @binding(0) var<storage, read_write> positions: array<VertexPackage>;
+@group(0) @binding(0) var<storage, read> positions: array<VertexPackage>;
 // todo: Check when i16 is supported
-@group(0) @binding(1) var<storage, read_write> indices: array<IndicesPackage>;
+@group(0) @binding(1) var<storage, read> indices: array<IndicesPackage>;
 
-@group(0) @binding(2) var<storage, read_write> bounds: array<array<vec4f, 2>>;
-@group(0) @binding(3) var<storage, read_write> contents: array<BinaryBvhNodeInfo>;
+@group(0) @binding(2) var<storage, read> bounds: array<array<vec4f, 2>>;
+@group(0) @binding(3) var<storage, read> contents: array<BinaryBvhNodeInfo>;
 
-@group(0) @binding(4) var<storage, read_write> normals: array<VertexPackage>;
+@group(0) @binding(4) var<storage, read> normals: array<VertexPackage>;
 
-@group(0) @binding(5) var<storage, read_write> indirectIndices: array<u32>;
+@group(0) @binding(5) var<storage, read> indirectIndices: array<u32>;
 
-@group(0) @binding(6) var<storage, read_write> objectDefinitions: array<ObjectDefinition>;
+@group(0) @binding(6) var<storage, read> objectDefinitions: array<ObjectDefinition>;
 
-@group(0) @binding(7) var<storage, read_write> materials: array<Material>;
+@group(0) @binding(7) var<storage, read> materials: array<Material>;
 
 @group(1) @binding(0) var texture: texture_storage_2d<rgba8unorm, write>;