fix: updated logo and favicon handling to correctly set paths in branding configuration #721
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
name: Pull Request
about: Create a pull request to contribute to the project
title: ''fix: updated logo and favicon handling to correctly set paths in branding configuration"
labels: ''
assignees: ''
Related Issue
Fixes #(issue)
Description of Changes
Modified the BrandingManager class's logic for handling of logo and favicon configurations. It ensures proper fallback to default assets when files are missing and updates the path to logo and favicon in branding dictionary in case the files are present in the specified location.
Type of Change
Testing
Verified that the frontend component successfully picks the custom logo and favicon from the specified path in the .toml file of the project.
Ensured that fallback mechanism works properly when the path to the custom logo/favicon is invalid and confirmed that the default icons are rendered correctly.
No regression issues observed with other components relying on BrandingManager.
Checklist