Skip to content

fix: updated logo and favicon handling to correctly set paths in branding configuration #721

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

ABCoder1
Copy link

@ABCoder1 ABCoder1 commented May 2, 2025


name: Pull Request
about: Create a pull request to contribute to the project
title: ''fix: updated logo and favicon handling to correctly set paths in branding configuration"
labels: ''
assignees: ''

Related Issue
Fixes #(issue)

Description of Changes
Modified the BrandingManager class's logic for handling of logo and favicon configurations. It ensures proper fallback to default assets when files are missing and updates the path to logo and favicon in branding dictionary in case the files are present in the specified location.

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update
  • New example
  • Test improvement

Testing
Verified that the frontend component successfully picks the custom logo and favicon from the specified path in the .toml file of the project.
Ensured that fallback mechanism works properly when the path to the custom logo/favicon is invalid and confirmed that the default icons are rendered correctly.
No regression issues observed with other components relying on BrandingManager.

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have run my code against examples and ensured no errors
  • Any dependent changes have been merged and published in downstream modules

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant