Skip to content

Adding Widget for Viewing PDFs #677

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

AkashWudali12
Copy link


name: Pull Request
about: Create a pull request to contribute to the project
title: 'Adding Widget for Viewing PDFs'
labels: ''
assignees: ''

Related Issue
Fixes #(issue)

Description of Changes

  • Added a new component that displays pdf documents as a widget.
  • Updated the configuration documentation for this component
  • Created example to show component

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update
  • New example
  • Test improvement

Testing

Screen.Recording.2025-04-16.at.4.25.05.PM.mov

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have run my code against examples and ensured no errors
  • Any dependent changes have been merged and published in downstream modules

@amrutha97 amrutha97 force-pushed the main branch 2 times, most recently from 6ac1dad to bdb2c4e Compare April 24, 2025 07:54
@shivam-singhal
Copy link
Member

@AkashWudali12 very cool! can you rebase your changes and resolve the merge conflicts?

@AkashWudali12 AkashWudali12 force-pushed the feature/added-document-component branch from cdb7607 to 139c070 Compare April 26, 2025 20:48
@AkashWudali12
Copy link
Author

@shivam-singhal Finished rebasing, the merge conflicts should be resolved now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants