Skip to content

Bump eth.zig to v0.8.0 (Signer abstraction)#10

Merged
koko1123 merged 1 commit into
mainfrom
koko/eth-zig-0.8
Jul 2, 2026
Merged

Bump eth.zig to v0.8.0 (Signer abstraction)#10
koko1123 merged 1 commit into
mainfrom
koko/eth-zig-0.8

Conversation

@koko1123

@koko1123 koko1123 commented Jul 1, 2026

Copy link
Copy Markdown
Contributor

What

  • Bumps the eth.zig pin v0.7.0 -> v0.8.0 (the Signer abstraction release: LocalSigner + AWS KMS-backed KmsSigner).
  • Migrates the three Wallet.init(allocator, private_key, &provider) call sites (context.zig, testing/mock_deployer.zig x2) to the new Wallet.initLocal(...) convenience - behavior is identical; v0.8.0's Wallet.init now takes a Signer (local key or KMS).

Why

Unblocks gator-liquidators' KMS migration: gator consumes both this SDK and eth.zig directly, and Zig only dedupes the shared eth package when both pin the SAME version - the SDK must move to v0.8.0 before gator can (otherwise duplicate vendored secp256k1 symbols fail the link with 107 errors).

Follow-up (not in this PR)

Context.init still takes a raw private key. A Context.initWithSigner(...) variant would let SDK consumers (e.g. the perpcity-bot-dev sandbox bot) sign via AWS KMS directly - worth adding once the gator pattern settles.

Verification

  • zig build test (Zig 0.16.0) - 342/342 pass.
  • zig fmt --check - clean.

After merge, cut tag v0.5.0 so gator can pin it.

Summary by CodeRabbit

  • Chores
    • Updated a dependency reference to a newer version and refreshed its checksum.
  • Bug Fixes
    • Switched wallet setup to use local initialization in app and test deployment paths for more reliable local behavior.

@coderabbitai

coderabbitai Bot commented Jul 1, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: fe863ab3-7694-4d21-a72d-88f2361b024b

📥 Commits

Reviewing files that changed from the base of the PR and between b0f260f and 2776d38.

📒 Files selected for processing (3)
  • build.zig.zon
  • src/context.zig
  • src/testing/mock_deployer.zig

📝 Walkthrough

Walkthrough

This PR bumps the eth.zig dependency reference and hash in build.zig.zon, and updates wallet construction calls in context.zig and mock_deployer.zig to use Wallet.initLocal instead of Wallet.init, with unchanged arguments.

Changes

Dependency Bump and Wallet Initialization

Layer / File(s) Summary
Dependency version bump
build.zig.zon
The eth dependency's url git ref is updated to v0.8.0 and the hash is updated to match.
Wallet.initLocal adoption
src/context.zig, src/testing/mock_deployer.zig
Wallet construction in PerpCityContext.init, deployAll, and registerModules now uses Wallet.initLocal(...) instead of Wallet.init(...), with the same allocator, private key, and provider arguments.

Estimated code review effort: 1 (Trivial) | ~3 minutes

Possibly related PRs

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly matches the main change: upgrading eth.zig to v0.8.0 and adapting to the new signer abstraction.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch koko/eth-zig-0.8

Comment @coderabbitai help to get the list of available commands.

@koko1123
koko1123 merged commit eb82d3c into main Jul 2, 2026
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant