Bump eth.zig to v0.8.0 (Signer abstraction)#10
Merged
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (3)
📝 WalkthroughWalkthroughThis PR bumps the eth.zig dependency reference and hash in build.zig.zon, and updates wallet construction calls in context.zig and mock_deployer.zig to use Wallet.initLocal instead of Wallet.init, with unchanged arguments. ChangesDependency Bump and Wallet Initialization
Estimated code review effort: 1 (Trivial) | ~3 minutes Possibly related PRs
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Wallet.init(allocator, private_key, &provider)call sites (context.zig,testing/mock_deployer.zigx2) to the newWallet.initLocal(...)convenience - behavior is identical; v0.8.0'sWallet.initnow takes aSigner(local key or KMS).Why
Unblocks gator-liquidators' KMS migration: gator consumes both this SDK and eth.zig directly, and Zig only dedupes the shared eth package when both pin the SAME version - the SDK must move to v0.8.0 before gator can (otherwise duplicate vendored secp256k1 symbols fail the link with 107 errors).
Follow-up (not in this PR)
Context.initstill takes a raw private key. AContext.initWithSigner(...)variant would let SDK consumers (e.g. the perpcity-bot-dev sandbox bot) sign via AWS KMS directly - worth adding once the gator pattern settles.Verification
zig build test(Zig 0.16.0) - 342/342 pass.zig fmt --check- clean.After merge, cut tag v0.5.0 so gator can pin it.
Summary by CodeRabbit