feat(onboarding): populated island + live arc orbit on the signed-out landing#72
Merged
Merged
Conversation
… landing
Signed-out visitors land on /onboarding behind the EdupassLogin surface
— previously a sparse mailbox-and-telescope island that read as "is
this thing on?" instead of "look what you can grow." Two pieces here:
A new `landingShowcase` prop on EngineHost (defaulting false so the
production onboarding ceremony is untouched) calls view.flowers.showAll
+ view.tree.showAll + view.butterflies.showAll once the engine is
ready, and the cleanup re-hides them so the sign-in transition lands
cleanly on the intentional empty stage. Wired from _app.tsx's signed-
out branch.
Camera was meant to slowly orbit the island via
camera.startLandingOrbit, but _app.tsx was passing `camera={null}` and
the JSX-bare `reducedMotion` prop (which evaluates to true) into
EdupassLogin — so the orbit never started, regardless of the preset.
SignedOutOnboarding now pulls the live engine through useEngine(),
hands EdupassLogin the real `view.camera`, and resolves
prefers-reduced-motion through a media-query hook instead of a
hardcoded true. The login-orbit preset bumps from 1°/s to 3°/s (~120s
per rotation, the speed where the sweep is unmistakable but never
dizzying), drops pitch from 35° to 28° for a more horizon-level
framing, and trims distance from 33.9 to 32 so the populated island
fills more of the frame.
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Signed-out visitors land on
/onboardingbehind the EdupassLogin surface. Previously it was a sparse mailbox-and-telescope island that read as "is this thing on?" rather than "look what you can grow." This PR fixes two things together:landingShowcaseprop onEngineHost(defaultfalse, so production onboarding is untouched) callsview.flowers.showAll()+view.tree.showAll()+view.butterflies.showAll()once the engine boots. Cleanup re-hides them so the sign-in transition lands cleanly on the intentional empty stage. Wired from_app.tsx's signed-out branch only.camera.startLandingOrbit, but_app.tsxwas passingcamera={null}and the JSX-barereducedMotionprop (which evaluates totrue) intoEdupassLogin— so the orbit was a no-op regardless of the preset.SignedOutOnboardingnow pulls the live engine throughuseEngine(), handsEdupassLoginthe realview.camera, and resolvesprefers-reduced-motionvia a media-query hook. Thelogin-orbitpreset bumps from 1°/s → 3°/s (~120 s per rotation — unmistakable sweep without dizziness), drops pitch 35° → 28° for a more horizon-level framing, and trims distance 33.9 → 32 so the populated island fills more of the frame.Test plan
/onboarding: see flowers + tree + butterflies on the island (not just mailbox + telescope).prefers-reduced-motionhonored — orbit does not start when reduced motion is on.login-orbitvia the dev camera HUD before, clearlocalStorage.removeItem('studentSpace.cameraTuner.overrides')to drop your override and see the new defaults.🤖 Generated with Claude Code