Skip to content

fix(student-space): reuse realtime readings#71

Merged
rezailmi merged 3 commits into
mainfrom
polish-student-space-shoreline-capture
May 25, 2026
Merged

fix(student-space): reuse realtime readings#71
rezailmi merged 3 commits into
mainfrom
polish-student-space-shoreline-capture

Conversation

@rezailmi
Copy link
Copy Markdown
Collaborator

Summary

  • keep onboarding greeting transparent over the live Student Space world so the sky is visible after sign-in
  • keep realtime capture review actions disabled while Mirror reading preparation is pending
  • reuse the prepared realtime Mirror reading when opening What I heard instead of preparing a second reading

Verification

  • pnpm check
  • pnpm build
  • git diff --check
  • ./node_modules/.bin/biome check src/components/student-space/capture/AskSheet.tsx src/components/student-space/onboarding/Greeting.tsx test/components/student-space/capture/capture-stack.test.tsx test/components/student-space/onboarding/OnboardingFlow.test.tsx
  • ./node_modules/.bin/vitest run test/components/student-space/capture/capture-stack.test.tsx test/components/student-space/onboarding/OnboardingFlow.test.tsx

Notes

  • pnpm test was run after merging origin/main and still fails in unrelated sheet suites: trajectory sheet tab lookup plus existing history/profile/dev pipeline style failures. The touched capture/onboarding suites pass.

Reza Ilmi added 3 commits May 25, 2026 01:05
Add generated texture assets for sand, cliff, and shore foam, tune the island water/sand shaders, and tighten the capture sheet reading/listening states. Replace the custom progression toast stack with a single Sonner-backed world status toast.
…shoreline-capture

# Conflicts:
#	src/components/student-space/capture/AskSheet.tsx
#	test/components/student-space/capture/capture-stack.test.tsx
@vercel
Copy link
Copy Markdown

vercel Bot commented May 25, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
sensemaking-agents Ready Ready Preview, Comment May 25, 2026 12:09am

@rezailmi rezailmi merged commit 1a753d8 into main May 25, 2026
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant