feat(student-space): polish shoreline and capture feedback#70
Merged
Conversation
Add generated texture assets for sand, cliff, and shore foam, tune the island water/sand shaders, and tighten the capture sheet reading/listening states. Replace the custom progression toast stack with a single Sonner-backed world status toast.
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Student Space now presents shoreline polish, capture flow, and world feedback as one coherent island moment. The beach reads softer and closer to the shore, capture sheets behave the same in onboarding and home, and world feedback uses a compact Sonner toast instead of stacked custom messages.
What Changed
Verification
git diff --checkpnpm checkpasses with existing static-only-class warnings intest/engine/Game.setRenderActive.test.tspnpm buildpasses with existing Vite externalization and chunk-size warningspnpm exec vitest run test/components/IslandProgressionOverlay.test.tsx test/engine/Progression.e2e.test.tsx test/components/student-space/capture/capture-stack.test.tsxpnpm exec vitest run --reporter=json --outputFile=/private/tmp/sensemaking-vitest-final.jsonstill has 11 failures in unrelated DevPalette, dev pipeline, world-data, host, history, and trajectory tests