Skip to content

Add Jest #12

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Add Jest #12

wants to merge 2 commits into from

Conversation

StrikeForceZero
Copy link
Owner

@StrikeForceZero StrikeForceZero commented Apr 24, 2017

Need to go through and remove chai references, then possibly swap out mocha and karma entirely

notes for myself when I come back to this:

https://github.com/react-boilerplate/react-boilerplate/blob/master/app/components/Img/tests/index.test.js#L36

<Img /> › should not adopt a srcset attribute

    TypeError: chai_1.expect(...).to.not.have.attr is not a function

      at Object.it (app\components\Img\tests\index.test.tsx:31:54)

related to #5

@StrikeForceZero StrikeForceZero changed the title [WIP] Add Jest #5 [WIP] Add Jest Apr 24, 2017
@StrikeForceZero StrikeForceZero changed the title [WIP] Add Jest Add Jest Apr 24, 2017
@StrikeForceZero StrikeForceZero self-assigned this Apr 24, 2017
@wer32
Copy link

wer32 commented Jun 15, 2017

Wow it works. I've migrate that pull request to my project. Thank you for your work!

@SimpleCookie
Copy link

I got nothing to add, just wanted to say good job! Keep at it.
I'm just about to give this repo a try. I'd love to contribute, but not sure if I can.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants