Skip to content

Feature: Allow streams to open in external player by default (#801) #899

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
ramirocardelli wants to merge 2 commits into
base: development
Choose a base branch
from
Open

Feature: Allow streams to open in external player by default (#801) #899

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1f5c263
Feature: Allow streams to open in external player by default (#801)
ramirocardelli Apr 26, 2025
fea8e63
refactor(Stream): remove unused console log and prevent button click …
ramirocardelli May 2, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/common/CONSTANTS.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -65,7 +65,7 @@ const EXTERNAL_PLAYERS = [
{
label: 'VLC',
value: 'vlc',
platforms: ['ios', 'visionos', 'android'],
platforms: ['ios', 'visionos', 'android', 'windows', 'linux', 'macos'],
},
{
label: 'MPV',
Expand Down
17 changes: 16 additions & 1 deletion src/routes/MetaDetails/StreamsList/Stream/Stream.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -51,7 +51,6 @@ const Stream = ({ className, videoId, videoReleased, addonName, name, descriptio
const popupMenuOnKeyDown = React.useCallback((event) => {
event.nativeEvent.buttonClickPrevented = true;
}, []);

const href = React.useMemo(() => {
return deepLinks ?
deepLinks.externalPlayer ?
Expand Down Expand Up @@ -101,6 +100,10 @@ const Stream = ({ className, videoId, videoReleased, addonName, name, descriptio
}
}, [videoId, videoReleased]);

const streamingUrl = React.useMemo(() => {
return deepLinks?.externalPlayer?.streaming;
}, [deepLinks]);

const onClick = React.useCallback((event) => {
if (profile.settings.playerType !== null) {
markVideoAsWatched();
Expand All @@ -109,6 +112,18 @@ const Stream = ({ className, videoId, videoReleased, addonName, name, descriptio
title: 'Stream opened in external player',
timeout: 4000
});
if (profile.settings.playerType === 'vlc' && streamingUrl) {
core.transport.dispatch({
action: 'StreamingServer',
args: {
action: 'PlayOnDevice',
args: {
device: 'vlc',
source: streamingUrl,
}
}
});
}
}

if (typeof props.onClick === 'function') {
Expand Down