Fix merging maps in ROS 2 Humble #815
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SteveMacenski
requested changes
Nov 17, 2025
Owner
SteveMacenski
left a comment
SteveMacenski
left a comment
There was a problem hiding this comment.
I stopped reviewing after a few checks; this doesn't appear to me to be simply backporting changes from current distros to humble. There are many changes that are not reflected in other more modern distributions. I think any updates need to be done on rolling first and then trickled down to other distros - that way any changes are reflected in all new distributions.
| "merge_maps_tool", shared_from_this()); | ||
|
|
||
| // timer to publish TFs for submaps | ||
| tf_timer_ = this->create_wall_timer( |
Owner
There was a problem hiding this comment.
I don't see this in the Rolling / Kilted branches. Where did this come from if its backporting?
| LocalizedRangeScanVector scans = mapper->GetAllProcessedScans(); | ||
| scans_vec_.push_back(scans); | ||
| num_submaps_++; | ||
| auto qos = rclcpp::QoS(rclcpp::KeepLast(1)).transient_local(); |
Owner
There was a problem hiding this comment.
This also isn't in the rolling/kilted/jazzy branches
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Basic Info
Description of contribution
ros2branch.Description of documentation updates
Future work that may be required in bullet points
ros2) branch.