-
Notifications
You must be signed in to change notification settings - Fork 143
Add plugin Better Keyboard #879
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add plugin Better Keyboard #879
Conversation
|
@chenx-dust Please fill out the Testing section of the PR template properly as noted in the Markdown comments in that section. You should also NOT be checking your own testing boxes. |
|
Corrected |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Your plugin is illegally licensed. You are allowed to MIT-license your edits, but you must include the BSD 3-Clause License from the plugin template at the bottom. Please include this beneath your MIT license.
BSD 3-Clause License
Copyright (c) 2022, Steam Deck Homebrew
All rights reserved.Redistribution and use in source and binary forms, with or without
modification, are permitted provided that the following conditions are met:
Redistributions of source code must retain the above copyright notice, this
list of conditions and the following disclaimer.Redistributions in binary form must reproduce the above copyright notice,
this list of conditions and the following disclaimer in the documentation
and/or other materials provided with the distribution.Neither the name of the copyright holder nor the names of its
contributors may be used to endorse or promote products derived from
this software without specific prior written permission.THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS "AS IS"
AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE
IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR PURPOSE ARE
DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT HOLDER OR CONTRIBUTORS BE LIABLE
FOR ANY DIRECT, INDIRECT, INCIDENTAL, SPECIAL, EXEMPLARY, OR CONSEQUENTIAL
DAMAGES (INCLUDING, BUT NOT LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR
SERVICES; LOSS OF USE, DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER
CAUSED AND ON ANY THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY,
OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Switched to BSD 3-Clasue license with original author info.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM for testing
|
Testing report: #880 (comment) |
Plugin Testing ReportInstalled Plugins
Specifications
IssuesHas the following major blocking issue(s): No SummaryThis plugin that is very useful for users who use a physical keyboard and input methods, solving the problem of input methods not working with a physical keyboard in game mode |
Add Better Keyboard to Plugin Store
Add support for physical keyboards in the virtual keyboard overlay to leverage the built-in IME, emoji panel, and other related features. When a physical keyboard is connected, the QWERTY keyboard can be hidden automatically, providing a cleaner and more convenient experience for users who primarily using physical keyboard.
Task Checklist
Developer
Plugin
Backend
Community
Testing