Skip to content

Conversation

@MegalonVII
Copy link
Contributor

@MegalonVII MegalonVII commented Oct 10, 2025

Transfer SDH-GameThemeMusic to MegalonVII

Updates the plugin to fix breakage in finding music with yt-dlp.

Reasons for Changing Ownership

Original plugin repo was archived on June 4th, 2025. I reached out to the original maintainer and asked if we could fork the project, to which he replied with a thumbs up reaction.
Message, look for OMGDuke reaction

Task Checklist

Developer

  • The original author or authorized maintainer of this plugin has either agreed to the transfer or has been unresponsive for an extended period as described above.
  • I am accept the responsibility of becoming the authorized maintainer of this plugin.
  • I have abided by the licenses of the libraries I am utilizing, including attaching license notices where appropriate.

Plugin

  • I have verified that my plugin works properly on the Stable and Beta update channels of SteamOS.
  • I have verified my plugin is unique or provides more/alternative functionality to a plugin already on the store.

Backend

  • No: I am using a custom backend other than Python.
  • Yes: I am using a tool or software from a 3rd party FOSS project that does not have it's dependencies statically linked.
  • No: I am using a custom binary that has all of it's dependencies statically linked.

Community

  • I have tested and left feedback on two other pull requests for new or updating plugins.
  • I have commented links to my testing report in this PR.

#880 (comment)
#862 (comment)

Testing

  • Tested by a third party on SteamOS Preview update channel.

@MegalonVII MegalonVII requested a review from a team as a code owner October 10, 2025 07:20
Copy link
Member

@EMERALD0874 EMERALD0874 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM for testing. @OMGDuke approval via Discord confirmed

@wheaney
Copy link
Contributor

wheaney commented Oct 14, 2025

Plugin Testing Report

Installed Plugins

  • Game Theme Music - 1.7.1-96106b0

Specifications

  • SteamOS 3.7.16 (Beta)
  • Steam 1759461205 (Steam Deck Stable)
  • Decky 3.1.11 (Prerelease)

Issues

Has the following major blocking issue(s): None
Has the following minor non-blocking issue(s): Only that the UI is a little confusing at first, it defaults to yt-dlp being disabled and provides a bunch of Invidious Instance options without an explanation for what it all means and what's recommended (I assume Invidious is since that's enabled by default). I've also noticed that the music doesn't play when returning from Suspend.

Summary

This is the first time I've used this plugin. Great job! Tested by viewing the Game Details for Elden Ring, Chrono Trigger, and a couple others. I tried the Download option toggled and untoggled and watched the yt-dlp process from top to see when it was running. All seemed to work well besides the minor issues noted.

@wheaney wheaney mentioned this pull request Oct 14, 2025
7 tasks
@MegalonVII MegalonVII mentioned this pull request Oct 14, 2025
7 tasks
@MegalonVII
Copy link
Contributor Author

MegalonVII commented Oct 14, 2025

Testing report for #880: #880 (comment)

@MegalonVII
Copy link
Contributor Author

MegalonVII commented Oct 14, 2025

Test report for #862: #862 (comment)

@github-actions github-actions bot added the not-plugin Not related to plugins themselves label Oct 14, 2025
@MegalonVII MegalonVII removed their assignment Oct 14, 2025
@github-project-automation github-project-automation bot moved this to 🆕 New in SDH Tracker Oct 15, 2025
@TrainDoctor TrainDoctor moved this from 🆕 New to 🔖 Ready for review in SDH Tracker Oct 15, 2025
@wheaney
Copy link
Contributor

wheaney commented Oct 15, 2025

As far as I can tell, switching between Beta and Preview right now pulls no updates. So it looks like my testing on SteamOS Beta v3.7.16 (build 20250929.1) should also tick off the "tested on Preview" requirement.

@wynn1212
Copy link
Contributor

wynn1212 commented Oct 15, 2025

Plugin Testing Report

Installed Plugins

  • Game Theme Music - 1.7.1-96106b0 (crashes on reading 'pendingProps')
  • PlayTime - 3.0.6-c772dfc
  • DeckyFileServer - 1.1.0-25cc88c
  • Pause Games - 1.0.1-868c9f9
  • SteamGridDB - 1.6.0-a742e2f (crashes on reading 'pendingProps')
  • BT Wake Control - 1.2.0-afd63bc
  • Decky-Terminal - 0.5.3-3f5bf40
  • Animation Changer - 1.3.2-01f5968
  • AutoFlatpaks - 1.6.8-4c7ad65
  • Bluetooth - 2.3.0
  • EmuDecky - 1.0.8-cca33c1
  • ProtonDB Badges - 1.1.0
  • PowerTools - 2.0.3
  • Notebook - 0.1.5
  • CSS Loader - 2.1.2
  • Battery Tracker - 0.2.0
  • Wine Cellar - 0.1.6-cf38b52 (crashes on reading 'ReactCurrentOwner')
  • Audio Loader - 1.6.1-a683513
  • NonSteamLaunchers - 1.0.1-2213950
  • DeckSettings - 1.3.0-de05be7

Specifications

  • SteamOS 3.7.16_20250929.1 (Preview)
    • Also on SteamOS 3.8_20251008.1000 (Main)
  • Steam 1760396898 (Beta)
  • Decky 3.2.0-pre1 (Pre-Release)

Issues

Has the following major blocking issue(s):

  • Context menu patch crashes the whole ui when pressing menu on a game after Decky 3.2.0-pre1 update.
    • For specific TypeError: Cannot read properties of undefined (reading 'pendingProps')
      screenshot

Has the following minor non-blocking issue(s): N/A

Summary

Everything seems to works fine (including yt-dlp part) until recent Steam Beta Client update which breaks Decky 3.1.11 and after Decky updates which breaks context menu patch in your plugins.

@EMERALD0874
Copy link
Member

@wheaney Your test report is considered invalid as it does not conform to the required template.

@wheaney
Copy link
Contributor

wheaney commented Oct 15, 2025

I've updated my testing comment.

@Josh5
Copy link
Contributor

Josh5 commented Oct 15, 2025

Plugin Testing Report

Installed Plugins

  • Deck Settings - 1.2.5-976d6fb
  • Game Theme Music - 1.7.1-96106b0

Specifications

  • SteamOS 3.7.13 (stable)
  • Steam 1751405894 (stable)
  • Decky 3.1.11 (stable)

Issues

Has the following major blocking issue(s):
I could not actually get it to work. Tried both yt-dl and invidious.
Has the following minor non-blocking issue(s): None

Summary

Attached image has errors from console.
image
image

@Josh5 Josh5 mentioned this pull request Oct 15, 2025
7 tasks
@MegalonVII
Copy link
Contributor Author

This should just be a quick hotfix for Bazzite support and for the Steam Client Beta that dropped on Oct 15. Also updates YT-DLP binary to latest release.

@EMERALD0874 EMERALD0874 removed the not-plugin Not related to plugins themselves label Oct 21, 2025
@EMERALD0874 EMERALD0874 added the plugin-maintainership Transferring a plugin on the Plugin Store from one repo to another identically named repo label Oct 21, 2025
@EMERALD0874
Copy link
Member

Please review the build logs and fix your plugin build.

@MegalonVII
Copy link
Contributor Author

For some reason, I can't remember why, I got rid of the pnpm-lock. That was why it said the build failed. Should be back now.

@xXJSONDeruloXx
Copy link
Contributor

xXJSONDeruloXx commented Oct 27, 2025

Plugin Testing Report

Installed Plugins

  • Pause Games — 1.0.1-868c9f9
  • BT Wake Control — 1.2.0
  • Audio Loader — 1.6.1-a683513
  • Decky-Framegen — 0.11.15
  • EmuDecky — 1.0.10
  • Web Browser — 1.4.2-f690b35
  • Crosshair — 1.1.0
  • Decky-Lookup — 0.1.0
  • HLTB for Deck — 2.0.4
  • Decky Terminal — 0.5.3
  • MangoPeel — 0.0.7-94c17113
  • SteamGridDB — 1.6.0
  • Battery Tracker — 0.2.0
  • CSS Loader — 2.1.2
  • Decky LSFG-VK — 0.11.2
  • Hibernado — 1.4.0
  • Game Theme Music = 1.7.1-4621abd

Specifications

  • SteamOS 3.7.16 (beta)
  • Steam 1759461205 (stable)
  • Decky 3.2.0-pre1 (prerelease)

Issues

Has the following major blocking issue(s):

None

Has the following minor non-blocking issue(s):

per the above report, I was also getting a decky crash on settings cog on steam beta client, switching to stable even on beta steam os it was stable and I could get into the theme music option on a game. I dont think this is the fault of the plugin itself.

After I manually selected an instance, all search results showed and I could choose one and have it behave as expected with all toggles tested and being respected from what I could tell. It was a bit disorienting seeing no results at first, and I was not immediately aware that its because the instance selection was blank. I think better UX would be either pre-selecting a valid one, or alternatively in the no music state direct user to choose a different instance and there may be more results if you try another.

Summary

tested by setting song on a few diff games, steam and non steam game shortcuts, and toggled things like default muted and use ytdlp and download without issue.

@xXJSONDeruloXx xXJSONDeruloXx mentioned this pull request Oct 27, 2025
7 tasks
@EMERALD0874
Copy link
Member

@MegalonVII I'm merging this, but please keep an eye out for issue reports in case someone has an issue similar to xXJSONDeruloXx

@EMERALD0874 EMERALD0874 merged commit 3a9956f into SteamDeckHomebrew:main Oct 28, 2025
2 checks passed
@github-project-automation github-project-automation bot moved this from 🔖 Ready for review to ✅ Done in SDH Tracker Oct 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

plugin-maintainership Transferring a plugin on the Plugin Store from one repo to another identically named repo

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

6 participants