-
Notifications
You must be signed in to change notification settings - Fork 143
Replace SDH-GameThemeMusic Plugin with MegalonVII fork #877
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM for testing. @OMGDuke approval via Discord confirmed
Plugin Testing ReportInstalled Plugins
Specifications
IssuesHas the following major blocking issue(s): None SummaryThis is the first time I've used this plugin. Great job! Tested by viewing the Game Details for Elden Ring, Chrono Trigger, and a couple others. I tried the Download option toggled and untoggled and watched the |
|
Testing report for #880: #880 (comment) |
|
Test report for #862: #862 (comment) |
|
As far as I can tell, switching between Beta and Preview right now pulls no updates. So it looks like my testing on SteamOS Beta v3.7.16 (build 20250929.1) should also tick off the "tested on Preview" requirement. |
Plugin Testing ReportInstalled Plugins
Specifications
IssuesHas the following major blocking issue(s):
Has the following minor non-blocking issue(s): N/A SummaryEverything seems to works fine (including yt-dlp part) until recent Steam Beta Client update which breaks Decky 3.1.11 and after Decky updates which breaks context menu patch in your plugins. |
|
@wheaney Your test report is considered invalid as it does not conform to the required template. |
|
I've updated my testing comment. |
Plugin Testing ReportInstalled Plugins
Specifications
IssuesHas the following major blocking issue(s): Summary |
|
This should just be a quick hotfix for Bazzite support and for the Steam Client Beta that dropped on Oct 15. Also updates YT-DLP binary to latest release. |
|
Please review the build logs and fix your plugin build. |
|
For some reason, I can't remember why, I got rid of the pnpm-lock. That was why it said the build failed. Should be back now. |
Plugin Testing ReportInstalled Plugins
Specifications
IssuesHas the following major blocking issue(s): None Has the following minor non-blocking issue(s): per the above report, I was also getting a decky crash on settings cog on steam beta client, switching to stable even on beta steam os it was stable and I could get into the theme music option on a game. I dont think this is the fault of the plugin itself. After I manually selected an instance, all search results showed and I could choose one and have it behave as expected with all toggles tested and being respected from what I could tell. It was a bit disorienting seeing no results at first, and I was not immediately aware that its because the instance selection was blank. I think better UX would be either pre-selecting a valid one, or alternatively in the no music state direct user to choose a different instance and there may be more results if you try another. Summarytested by setting song on a few diff games, steam and non steam game shortcuts, and toggled things like default muted and use ytdlp and download without issue. |
|
@MegalonVII I'm merging this, but please keep an eye out for issue reports in case someone has an issue similar to xXJSONDeruloXx |



Transfer SDH-GameThemeMusic to MegalonVII
Updates the plugin to fix breakage in finding music with yt-dlp.
Reasons for Changing Ownership
Original plugin repo was archived on June 4th, 2025. I reached out to the original maintainer and asked if we could fork the project, to which he replied with a thumbs up reaction.
Message, look for OMGDuke reaction
Task Checklist
Developer
Plugin
Backend
Community
#880 (comment)
#862 (comment)
Testing