Skip to content

Conversation

@martinpl
Copy link
Contributor

@martinpl martinpl commented Sep 17, 2025

Music Control

Update restores functionality lost in (not) recent changes.

Reasons for Changing Ownership

Current maintainer step down, plugin don't work for a while. Maintainer agreed to forking / basing code on his work.

mirobouma/MusicControl#17 (comment)
https://discord.com/channels/960281551428522045/1020218094293106729/1415707759084834856

Task Checklist

Developer

  • The original author or authorized maintainer of this plugin has either agreed to the transfer or has been unresponsive for an extended period as described above.
  • I am accept the responsibility of becoming the authorized maintainer of this plugin.
  • I have abided by the licenses of the libraries I am utilizing, including attaching license notices where appropriate.

Plugin

  • I have verified that my plugin works properly on the Stable and Beta update channels of SteamOS.
  • I have verified my plugin is unique or provides more/alternative functionality to a plugin already on the store.

Backend

  • No: I am using a custom backend other than Python.
  • No: I am using a tool or software from a 3rd party FOSS project that does not have it's dependencies statically linked.
  • No: I am using a custom binary that has all of it's dependencies statically linked.

Testing

  • Tested by a third party on SteamOS Stable or Beta update channel.

@AAGaming00
Copy link
Member

Code LGTM but can you provide proof you were given permission to change the license to GPL from MIT?

@martinpl
Copy link
Contributor Author

Actually i don't have that, @mirobouma is this okay or revert to MIT?

@mirobouma
Copy link
Contributor

Actually i don't have that, @mirobouma is this okay or revert to MIT?

Hereby you have my permission 👍

@AAGaming00
Copy link
Member

Cool

@github-actions
Copy link

github-actions bot commented Oct 1, 2025

This pull request is stale as no updates or testing reports have been posted within the last 7 days. Please ensure you are actively recruiting testers or resolving the issues discussed. If you do not remove the stale label or comment, this will be closed in 7 days. Please close this pull request if you need more time to resolve issues so we can keep our repo healthy.

@github-actions github-actions bot added the stale label Oct 1, 2025
@EMERALD0874
Copy link
Member

@martinpl Please rebase from main, you are attempting to deploy three plugins.

@martinpl martinpl force-pushed the replace-MusicControl-repo branch from e054e76 to b8deb26 Compare October 3, 2025 17:27
@martinpl martinpl closed this Oct 3, 2025
@martinpl
Copy link
Contributor Author

martinpl commented Oct 3, 2025

@EMERALD0874 i move it to #871 🤞

@martinpl martinpl deleted the replace-MusicControl-repo branch November 2, 2025 17:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants