Support basic config files #6
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was
linked to
issues
Nov 14, 2024
Closed
Leguan16
approved these changes
Nov 15, 2024
Member
Leguan16
left a comment
Leguan16
left a comment
There was a problem hiding this comment.
Automatically load all files within the resources/menus/ directory.
testplugin/src/main/java/net/staticstudios/testplugin/TestMenuPlugin.java
Show resolved
Hide resolved
menus/src/main/java/net/staticstudios/menus/parser/ButtonParser.java
Outdated
Show resolved
Hide resolved
menus/src/main/java/net/staticstudios/menus/parser/MenuRegistry.java
Outdated
Show resolved
Hide resolved
Leguan16
requested changes
Nov 15, 2024
Member
Leguan16
left a comment
Leguan16
left a comment
There was a problem hiding this comment.
Automatically load all files within the resources/menus/ directory.
Leguan16
approved these changes
Nov 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the ability to read static menus from config files. static refers to the definition, not the static in static studios
This PR also adds runServer and a test plugin for testing
The format of the config files matches the legacy format used internally. Note that this version does not have support for placeholders as it doesn't really make sense. This is strictly for simple menus. Most menus in
static-skyblockwill have to be migrated to be defined in java. The main menu however, can stay defined as a file.There is also no support for
codeactions oropen-menuactions as using acommandaction is cleaner and encourages more flexibility