SpeziViews

[pauljohanneskraft]

SpeziViews

♻️ Current situation & Problem

Link any open issues or pull requests (PRs) related to this PR. Please ensure that all non-trivial PRs are first tracked and discussed in an existing GitHub issue or discussion.

⚙️ Release Notes

Add a bullet point list summary of the feature and possible migration guides if this is a breaking change so this section can be added to the release notes.
Include code snippets that provide examples of the feature implemented or links to the documentation if it appends or changes the public interface.

📚 Documentation

Please ensure that you properly document any additions in conformance to Spezi Documentation Guide.
You can use this section to describe your solution, but we encourage contributors to document your reasoning and changes using in-line documentation.

✅ Testing

Please ensure that the PR meets the testing requirements set by CodeCov and that new functionality is appropriately tested.
This section describes important information about the tests and why some elements might not be testable.

📝 Code of Conduct & Contributing Guidelines

By submitting creating this pull request, you agree to follow our Code of Conduct and Contributing Guidelines:

• I agree to follow the Code of Conduct and Contributing Guidelines.

[codecov]

Codecov Report

Attention: Patch coverage is 42.36111% with 498 lines in your changes missing coverage. Please review.

Project coverage is 40.24%. Comparing base (11ae70a) to head (ace70d4).
Report is 1 commits behind head on main.

Files with missing lines	Patch %	Lines
...e/design/component/AsyncImageResourceComposable.kt	0.00%	61 Missing ⚠️
...sign/views/validation/views/VerifiableTextField.kt	32.95%	31 Missing and 26 partials ⚠️
...design/views/personalinfo/UserProfileComposable.kt	47.06%	31 Missing and 5 partials ⚠️
...e/design/views/personalinfo/fields/NameFieldRow.kt	31.82%	24 Missing and 6 partials ⚠️
.../design/views/personalinfo/PersonNameComponents.kt	43.14%	28 Missing and 1 partial ⚠️
...re/design/views/views/layout/DescriptionGridRow.kt	40.91%	24 Missing and 2 partials ⚠️
...ezi/core/design/views/views/views/text/Markdown.kt	45.46%	14 Missing and 10 partials ⚠️
.../design/views/personalinfo/fields/NameTextField.kt	36.12%	19 Missing and 4 partials ⚠️
...core/design/views/validation/ValidationModifier.kt	53.34%	14 Missing and 7 partials ⚠️
.../spezi/core/design/component/AsyncImageResource.kt	0.00%	20 Missing ⚠️
... and 21 more

Additional details and impacted files

@@             Coverage Diff              @@
##               main     #140      +/-   ##
============================================
+ Coverage     39.67%   40.24%   +0.58%     
- Complexity      799      834      +35     
============================================
  Files           267      294      +27     
  Lines         10567    11361     +794     
  Branches       1485     1692     +207     
============================================
+ Hits           4191     4571     +380     
- Misses         6014     6319     +305     
- Partials        362      471     +109     

Flag	Coverage Δ
uitests	36.51% <41.27%> (+3.01%)	⬆️
unittests	31.66% <7.57%> (-1.89%)	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines	Coverage Δ
...views/validation/configuration/ValidationEngine.kt	100.00% <100.00%> (ø)
...ion/configuration/ValidationEngineConfiguration.kt	100.00% <100.00%> (ø)
...validation/state/CapturedValidationStateEntries.kt	100.00% <100.00%> (ø)
...du/stanford/spezi/modules/contact/model/Contact.kt	100.00% <100.00%> (ø)
...ucation/videos/component/ExpandableVideoSection.kt	62.58% <100.00%> (-0.21%)	⬇️
...sign/views/validation/CascadingValidationEffect.kt	50.00% <50.00%> (ø)
...d/spezi/core/design/views/views/model/ViewState.kt	66.67% <66.67%> (ø)
...n/views/validation/state/FailedValidationResult.kt	77.78% <77.78%> (ø)
...ehf/contact/data/ContactDocumentToContactMapper.kt	68.00% <40.00%> (+1.34%)	⬆️
...i/core/design/component/ImageResourceComposable.kt	24.14% <40.00%> (+24.14%)	⬆️
... and 26 more

... and 6 files with indirect coverage changes

---

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 11ae70a...ace70d4. Read the comment docs.

---- 🚨 Try these New Features:

• Flaky Tests Detection - Detect and resolve failed and flaky tests

[eldcn]

I did not manage to review the whole PR as it is relatively large, please focus on these comments first (I tried to include ready code snippets in general). Will continue later on or tomorrow with the rest

[eldcn]

Part 2 of review, will continue again tomorrow

[eldcn]

Looks very good and I think we are good to go with merging this iteration 👏 Thanks for reiterating over the comments, looking forward to the account PR where you use these components, great job 🚀