add check for cyc controller, delete extra transform#95
Open
kavyasreedhar wants to merge 4 commits intomasterfrom
Open
add check for cyc controller, delete extra transform#95kavyasreedhar wants to merge 4 commits intomasterfrom
kavyasreedhar wants to merge 4 commits intomasterfrom
Conversation
mbstrange2
reviewed
Dec 22, 2020
| # Now transforms ranges and strides | ||
| (tform_extent, tform_cyc_strides) = transform_strides_and_ranges(ctrl_ranges, ctrl_cyc_strides, ctrl_dim) | ||
| tform_cyc_strides = None | ||
| if ctrl_cyc_strt is not None: |
Collaborator
There was a problem hiding this comment.
What happens if it is None?
Collaborator
Author
There was a problem hiding this comment.
If it's None, we don't call transform_strides_and_ranges on a controller that doesn't exist, which will throw some error. However, I don't remember what caused the need for this when we were testing with Joey before...I think the controller didn't exist for some reason, but that doesn't seem to make sense now...
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
small things that popped up when doing stuff for Joey...