add loading child widget to networkWidget #251
Conversation
|
|
| @@ -10,8 +10,8 @@ part 'stac_network_widget.g.dart'; | |||
| abstract class StacNetworkWidget with _$StacNetworkWidget { | |||
| const factory StacNetworkWidget({ | |||
| required StacNetworkRequest request, | |||
| Map<String, dynamic>? loading, | |||
| }) = _StacNetworkWidget; | |||
There was a problem hiding this comment.
Can we also add support for the error widget?
There was a problem hiding this comment.
yes, will add to the PR, I already added it but was too lazy to test it so did not include
|
Hey @aktxyz!! Can you check the formatting? The format checks are failing. |
yes, will fix the formatting -- my default width is set higher than the 1928 IBM punch card standard :) I mainly wanted to check if this was on the right track. For the error option, I actually added that then realized I needed some http endpoint to respond with an error ! will do that also |
|
Yup, you are on the right track. Keep going 💯 |
|
Hey @aktxyz!! Any update on this PR? :) |
this seems to work, the loadingWidget support was already in the NetowrkWidget, just not exposed via the json model