Explicitly set arg_seperator #210
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ziegenberg
force-pushed
the
explicitly-set-arg_seperator
branch
from
b73e581 to
ab3a5f1
Compare
|
I added a test. |
|
The failing rector tests are probably due to rectorphp/rector#8395. |
|
Thanks. That's a nice addition. |
|
No worries for Rector. I will fix it. |
|
I found this while I was working on this: https://tracker.moodle.org/browse/MDL-79678 If we could have a version that includes this fix soon, that would be wonderful. |
|
Excellent. Can you target 11.2? It seems it is more a big fix than a new feature. |
|
I'll rebase onto branch 11.2.x and force push. Is that okay with you? |
We cannot rely on arg_separator.output to be set to it's default '&', therefore we explicitly set it here. Signed-off-by: Daniel Ziegenberg <[email protected]>
ziegenberg
force-pushed
the
explicitly-set-arg_seperator
branch
from
ab3a5f1 to
1065022
Compare
|
Rebased and force-pushed. |
|
Many thanks 👍🏼 |
|
Many thanks for the quick release! 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We cannot rely on
arg_separator.outputto be set to it's default '&', therefore we explicitly set it here.Target branch: 11.3.x