Open
Conversation
Member
Author
|
In 4d80e0b, the create time for repost was updated to use datetime(python) and Datetime(mysql). This is a BREAKING change for the current project and means no more compactability for the previous database schema. However, by extracting the common create time parser, the repost and comment tasks can be maintained at once. And also the reposts can be filtered by create time via where. So this should be a helpful update. Since the last PR heard no comments till today, I may merge this in the coming few weeks if there is still no any comments. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Use system's cert instead of disable InsecureRequestWarning
https://urllib3.readthedocs.io/en/latest/advanced-usage.html#ssl-warnings
https://urllib3.readthedocs.io/en/latest/user-guide.html#ssl
https://stackoverflow.com/questions/42982143/python-requests-how-to-use-system-ca-certificates-debian-ubuntu
https://stackoverflow.com/a/33717517/1695680
In this PR, we use system's cert rather than third-party certs. However, this will downgrade the compatibility since only ubuntu(debian) use this path.