Performance and Security Updates #3
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sprectre mits, Intel JCC perf boost.
String Formatting: Updated SK_FormatStringW to use a 4096-character stack buffer with vswprintf_s and a dynamic fallback if needed, ensuring safe formatting without overruns. Path Retrieval: Replaced fixed-size arrays for current directory and executable paths with dynamic allocation via std::wstring and std::vector to avoid buffer overflow issues. Cleaner Command-Line Parsing: Switched from multiple wcsstr calls to std::wstring::find for processing command-line arguments. Enhanced Safety: Added a check for the GetProcAddress result before calling RunDLL_InjectionManager. C++ Updates: Replaced all instances of NULL with nullptr.
Version bump and accompanying text.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
String Formatting:
Updated SK_FormatStringW to use a 4096-character stack buffer with vswprintf_s and a dynamic fallback if needed, ensuring safe formatting without overruns.
Path Retrieval:
Replaced fixed-size arrays for current directory and executable paths with dynamic allocation via std::wstring and std::vector to avoid buffer overflow issues.
Cleaner Command-Line Parsing:
Switched from multiple wcsstr calls to std::wstring::find for processing command-line arguments.
Enhanced Safety:
Added a check for the GetProcAddress result before calling RunDLL_InjectionManager.
C++ Updates:
Replaced all instances of NULL with nullptr.