Skip to content

Implement document approval workflow API#3

Open
Dimwiddle wants to merge 5 commits into
mainfrom
with/specleft-mcp
Open

Implement document approval workflow API#3
Dimwiddle wants to merge 5 commits into
mainfrom
with/specleft-mcp

Conversation

@Dimwiddle
Copy link
Copy Markdown
Contributor

Summary

  • build document lifecycle, review, delegation, and escalation API flows backed by SQLAlchemy
  • generate SpecLeft feature specs and map each scenario to tests
  • add notification tracking and escalation history in responses

Testing

  • uv run pytest

@Dimwiddle
Copy link
Copy Markdown
Contributor Author

Dimwiddle commented Feb 24, 2026

Retrospective

  • Failed test runs before green: 3 (initial module import errors, escalation reviewer_ids, escalation event visibility)
  • Effort split: spec externalisation 20%, implementation 45%, testing 20%, behaviour verification 15%
  • Clarity grades: spec externalisation A-, implementation B+, testing B, behaviour verification B+
  • What went well: SpecLeft flow kept scenarios aligned with tests; iterating via targeted tests made edge cases clear
  • What was missed/inefficient: handling test client imports and escalation visibility required extra passes; initial reviewer_ids handling missed escalations
  • Next time: wire test harness + app imports earlier and validate escalation/reviewer aggregation upfront before full test run

Session usage overview

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant