fix: append sheets instead of inserting at explicit index in queued multi-sheet exports#4373
Open
YoussefMansour9 wants to merge 1 commit into
Conversation
…ulti-sheet exports
YoussefMansour9
force-pushed
the
fix/queue-export-multisheet-phpspreadsheet5
branch
from
e00e9f1 to
1a4a280
Compare
Member
|
Is this still needed now we have #4365 (comment) merged ? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #4365
In
QueueExport::handle(), passing$sheetIndextoaddNewSheet()causesSpreadsheet::createSheet($index)to incrementactiveSheetIndexin PhpSpreadsheet 5, leaving it out of bounds. Appending without explicit index preserves order sincedisconnectWorksheets()was already called.