[BUG] : Queued exports drop root-level concerns#4329
Open
imhayatunnabi wants to merge 3 commits into
Open
Conversation
Contributor
Author
|
@patrickbrouwers any update on this pr ? |
Member
|
Sorry currently not comfortable merging this, this might introduce breaking changes for people. If you can target it to 4.x I'll revisit |
64cf79e to
90eab65
Compare
Contributor
Author
|
Hello @patrickbrouwers , |
1 task
|
This bug report has been automatically closed because it has not had recent activity. If this is still an active bug, please comment to reopen. Thank you for your contributions. |
Contributor
Author
|
@patrickbrouwers fixed the conflict in merge. |
|
This bug report has been automatically closed because it has not had recent activity. If this is still an active bug, please comment to reopen. Thank you for your contributions. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Please take note of our contributing guidelines: https://docs.laravel-excel.com/3.1/getting-started/contributing.html
Filling out the template is required. Any pull request that does not include enough information to be reviewed in a timely manner may be closed at the maintainers' discretion.
1️⃣ Why should it be added? What are the benefits of this change?
2️⃣ Does it contain multiple, unrelated changes? Please separate the PRs out.
3️⃣ Does it include tests, if possible?
QueuedExportTest::test_queued_exports_apply_root_concerns).4️⃣ Any drawbacks? Possible breaking changes?
5️⃣ Mark the following tasks as done:
6️⃣ Thanks for contributing! 🙌
Related Issue: #4328