Skip to content

[BUG] : Queued exports drop root-level concerns#4329

Open
imhayatunnabi wants to merge 3 commits into
SpartnerNL:4.xfrom
imhayatunnabi:fix/queued-export-root-concerns
Open

[BUG] : Queued exports drop root-level concerns#4329
imhayatunnabi wants to merge 3 commits into
SpartnerNL:4.xfrom
imhayatunnabi:fix/queued-export-root-concerns

Conversation

@imhayatunnabi

@imhayatunnabi imhayatunnabi commented Nov 6, 2025

Copy link
Copy Markdown
Contributor

Please take note of our contributing guidelines: https://docs.laravel-excel.com/3.1/getting-started/contributing.html
Filling out the template is required. Any pull request that does not include enough information to be reviewed in a timely manner may be closed at the maintainers' discretion.

1️⃣ Why should it be added? What are the benefits of this change?

  • Aligns queued exports with synchronous behaviour so root-level concerns (properties, events, CSV settings) are preserved.

2️⃣ Does it contain multiple, unrelated changes? Please separate the PRs out.

  • No — focused only on this issue.

3️⃣ Does it include tests, if possible?

  • Yes (QueuedExportTest::test_queued_exports_apply_root_concerns).

4️⃣ Any drawbacks? Possible breaking changes?

  • None expected; restores missing functionality.

5️⃣ Mark the following tasks as done:

  • Take note of the contributing guidelines.
  • Checked the pull requests to ensure that another person hasn't already submitted a fix.
  • Checked the codebase to ensure that your feature doesn't already exist.
  • Added tests to ensure against regression.

6️⃣ Thanks for contributing! 🙌

Related Issue: #4328

@imhayatunnabi

Copy link
Copy Markdown
Contributor Author

@patrickbrouwers any update on this pr ?

@patrickbrouwers

Copy link
Copy Markdown
Member

Sorry currently not comfortable merging this, this might introduce breaking changes for people. If you can target it to 4.x I'll revisit

@imhayatunnabi imhayatunnabi force-pushed the fix/queued-export-root-concerns branch from 64cf79e to 90eab65 Compare January 14, 2026 19:06
@imhayatunnabi imhayatunnabi changed the base branch from 3.1 to 4.x January 14, 2026 19:07
@imhayatunnabi

Copy link
Copy Markdown
Contributor Author

Hello @patrickbrouwers ,
Thanks for the feedback. I've updated the PR to target 4.x as requested and rebased the changes. All tests are passing.

@stale

stale Bot commented Mar 21, 2026

Copy link
Copy Markdown

This bug report has been automatically closed because it has not had recent activity. If this is still an active bug, please comment to reopen. Thank you for your contributions.

@stale stale Bot closed this Mar 21, 2026
@stale stale Bot removed the stale label Mar 21, 2026
@imhayatunnabi

Copy link
Copy Markdown
Contributor Author

@patrickbrouwers fixed the conflict in merge.

@stale stale Bot added the stale label Jun 14, 2026
@stale

stale Bot commented Jun 26, 2026

Copy link
Copy Markdown

This bug report has been automatically closed because it has not had recent activity. If this is still an active bug, please comment to reopen. Thank you for your contributions.

@stale stale Bot closed this Jun 26, 2026
@stale stale Bot removed the stale label Jun 26, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants