Repository navigation
Address the remaining v0.9.0 P3 feedback - #310
Merged
Merged
Conversation
- Payload schemas: contracts/change-payloads.v1.schema.json describes
change_prepare.payload for all 139 kinds (derived from the worker parsers
and audited against them); resources tia://change-payloads/{kind} and
tia://contracts/{name}.
- hmi_inspect: rowMode (full/compact/hash), excludeSystem for section=model,
page limit up to 1000, a page summary first and modelContentHash.
- Change results: detail levels (summary/standard/full), stageTimings, and
_meta tiaMcp/durationMs on every tool result.
- project_snapshot_capture: per-step progress, reviewUri, reason text in the
summary, nodeCountScope.
- Lock owners: ProjectLocked names the Portal holding a project;
tia_session_status lists every visible Portal.
- simulation_download failures report ticketState and a remediation.
- Early per-operation HMI target.kind checks; stale prepared change
directories are pruned after 24 h; --timeout-seconds up to 3600.
- call_parameter_set, call_connection_set and the graphical edits take
items, one item per block, each read back against its own document.
- The reference client fails fast when the Host exits.
- Test fixes surfaced on this workstation: the PLCSIM API probe path in the
component boundary test and the moved Limit method in the watch boundary
test; the deployment test checks the new 3600 s bound.
Worker changes are covered offline only; their native runs are tracked in
docs/TODO.md.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
- ProjectLocked no longer pre-empts TIA: the open is attempted, and only a native failure is reported with the other Portal named. - The stale-preparation sweep runs only for the Host's changes folder and only removes changes still prepared; prepare_failed journals and coordinator workspaces are kept. - Payload schemas: constraints the audit could not cite are dropped (block attribute value types, VCI and upload reference lengths); 151 payloads the worker accepted in retained journals validate, apart from the retired safety_drive_tags tags form. - Feature catalog 0.4.184 notes each touched feature as offline only; TODO rewords the evidence-size and paging entries and opens a box for totalItems/pageCount, schema examples and per-section HMI rules. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
main landed natively checked versions of three overlapping items; this
merge keeps them and layers the branch's additions on top:
- Batches: main's call_parameter_set and graphical batches (preflight in
its own directory, per-item readback); call_connection_set stays
unbatched, as on main. The branch's own batch code is dropped.
- hmi_inspect: main's excludeSystem (with OPC UA alarm types), rowMode
full/compact and sectionContentSha256; the branch keeps page with
stoppedBy, the 1000-row limit and the early target.kind check, and drops
its hash mode and modelContentHash.
- Capture: main's stage progress and remoteAccess; the branch keeps the
reason text in summary and nodeCountScope, and drops reviewUri and its
separate step notifications. Every result still carries durationMs.
- Contracts: main's tia://contracts resources and change-kinds.v1.json;
tia://change-payloads/{kind} reads change-payloads.v1.schema.json through
them. Payload schemas no longer allow items on call_connection_set.
- Feature catalog 0.4.185, release matrix, source bindings and the change
kind index regenerated.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
ExactClient and several runners build a Client with __new__ and set only the attributes they use, and their fake processes may report an exit while writes are still expected. The fail-fast path now reads exited, error_reader and poll defensively and no longer refuses a write because poll() reports an exit; a dead pipe still fails on the write and a closed stdout on the read. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes the open P3 items from the v0.9.0 user feedback in
docs/TODO.md.Added
contracts/change-payloads.v1.schema.jsondescribeschange_prepare.payloadfor all 139 kinds (111 inline, 28 pointing to the HMI, library and typed graphical contracts). Resourcestia://change-payloads/{kind}andtia://contracts/{name}.scripts/test_change_payload_schemas.py, and 151 payloads the worker accepted in retained journals. The only mismatches were the retiredsafety_drive_tagstagsform.hmi_inspect:rowMode(full/compact/hash),excludeSystemforsection=model, a page limit up to 1000, apagesummary first andmodelContentHash.detail(summary/standard/full),stageTimings, and_meta["tiaMcp/durationMs"]on every tool result.project_snapshot_capture: per-step progress (with aprogressToken),reviewUri, the reason text insummary, andnodeCountScope.tia_session_statuslists every visible Portal (portals). A failedproject_opennames the other Portal that has the project open (ProjectLocked); TIA still decides whether the open is possible.call_parameter_set,call_connection_setand the graphical edits takeitems, one item per block, and each block is read back against its own prepared document.Changed
--timeout-secondsgoes up to 3600 s.simulation_downloadreportsticketStateand a remediation.target.kindis checked before the preservation capture.change_prepareremovespreparedchange directories older than 24 h that no worker holds; each removal is logged.Test fixes surfaced on a TIA workstation
Limitmethod that moved on 9 November.Verification
scripts/Test.ps1) passes.docs/TODO.md, along withtotalItems/pageCount, schema examples and per-section HMI rules.🤖 Generated with Claude Code