Refactored toApiFormat.js to use json-pointer #130
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…a transmission is modified by toApiFormat()
…xcluded from case manipulation
…ers to be used to define exclusions
…ated to the email_rfc822 problem
|
Would you consider this a breaking change? Can we keep it on the 1.x release line? |
|
Sorry I forgot to mention that this is not a breaking change. Behaviour is the same as before. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added tests that showed the problem with
email_rfc822keys. Refactored toApiFormat.js to use json-pointer, which should allow for more flexible exclusion definition going forward.