Merge pull request #22 from SparkPost/feature/issue-21

Fixes Issue #21

lib/transmission.js

@@ -122,6 +122,15 @@ module.exports = {
     request.post(options, function(err, res, body) {
       if (err) {
         callback(err);
+      } else if (typeof res === 'undefined' || typeof res.body === 'undefined') {
+        /*
+         * If we're in here then something very strange has happened because we didn't
+         * get a properly formatted response from the API call, so give generic error
+         * since that's the best we can do in this case
+         *
+         * Note that this is the case for both successful responses and error responses
+         */
+        callback(new Error('Unexpected error occurred while trying to send transmission'));
       } else if (res.statusCode !== 200) {
         callback(res.body.errors);
       } else {

test/mocks/request.js

@@ -15,7 +15,7 @@ MockRequest.prototype.get = function(options, callbackFunction) {
 };
 
 MockRequest.prototype.post = function(options, callbackFunction) {
-  var response = {error: this.error, response: this.response, body: this.response.body};
+  var response = {error: this.error, response: this.response, body: this.response.body || undefined};
   callbackFunction(response.error, response.response, response.body);
 };
 

test/spec/transmissions.spec.js

@@ -170,6 +170,18 @@ describe('Transmissions Library', function() {
       MockRequest.restore();
     });
 
+    it('should return a generic error when we get an ill-formed response from the API', function() {
+      MockRequest.response = {}; // no body
+
+      transmission.send({}, function(err, res) {
+        expect(res).to.be.undefined;
+        expect(err).to.match(/Unexpected error occurred while trying to send transmission/);
+      });
+
+      MockRequest.restore();
+    });
+
+
     it('should return an error if the status code is anything other than 200', function() {
       MockRequest.response.statusCode = 500;
       MockRequest.response.body.errors[0] = 'first error';