-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement telemetry memory #344
Draft
jeromehue
wants to merge
13
commits into
master
Choose a base branch
from
implement-telemetry-memory
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Implement a TelemetryRecord type following the wiki specification, includes Serialize/Deserialize functions.
- Also fix a typo in one of TelemetryRecord field
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #344 +/- ##
=======================================
Coverage 81.98% 81.98%
=======================================
Files 49 49
Lines 1782 1782
Branches 77 77
=======================================
Hits 1461 1461
Misses 321 321 ☔ View full report in Codecov by Sentry. |
Also, separate TelemetryRecord to its own files
Turn TelemetryRecord.ipp to TelemetryRecord.cpp Add TelemetryRecord.cpp to sources of Sts1CobcSw_FramSections
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
TelemetryRecord
struct holding the telemetry variables.FramRingArray
ofTelemetryRecord
s telemetryMemory variable.Added files :
TelemetryMemory.hpp
,TelemetryMemory.cpp
.Fixes #179
Fixes parts of #198