Add functions and strong types for Rodos and real time #319
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #319 +/- ##
==========================================
- Coverage 96.11% 94.06% -2.05%
==========================================
Files 21 22 +1
Lines 643 657 +14
==========================================
Hits 618 618
- Misses 25 39 +14 ☔ View full report in Codecov by Sentry. |
PatrickKa
changed the title
…do some minor syntactic fixes
Also fix publishing the delay in seconds but using it like a normal Rodos duration, i.e., in nanoseconds.
PatrickKa
force-pushed
the
strong-types-for-time-units
branch
from
7d65f6b to
0fd29a2
Compare
It must be default constructible for usage in `RODOS::Commbuffer` and `strong::difference` perfectly models the properties of a duration. It can be added and subtracted, scaled and divided with the underlying type, and dividing two `Duration`s yields the unterlying type.
PatrickKa
changed the title
They are all just a single line and at least `CurrentXxxTime()` might be called frequently so enabling inlining without LTO seems like a good idea.
PatrickKa
force-pushed
the
strong-types-for-time-units
branch
from
2ad7048 to
7847bef
Compare
I have no idea why TopicsAndSubscribers.cpp was specified as an additional source file, but it caused errors so I removed it.
PatrickKa
force-pushed
the
strong-types-for-time-units
branch
from
7847bef to
3c92fdf
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #320
Fixes #221
Also adds conversion functions between Rodos and real time.