Test error handling for SPI code #315
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #315 +/- ##
==========================================
- Coverage 83.35% 79.34% -4.02%
==========================================
Files 37 47 +10
Lines 1352 1578 +226
Branches 50 57 +7
==========================================
+ Hits 1127 1252 +125
- Misses 225 326 +101 ☔ View full report in Codecov by Sentry. |
PatrickKa
force-pushed
the
test-error-handling-for-spi
branch
from
7e5fde1 to
994e1bb
Compare
PatrickKa
force-pushed
the
test-error-handling-for-spi
branch
from
cd593b3 to
80b9b51
Compare
PatrickKa
requested changes
Aug 29, 2024
There was a problem hiding this comment.
FlashMock.hpponly needs to declare what is necessary for mocking in addition toFlash.hpp. That means you need to remove everything up to and includingextern hal::Spi spi;and includeFlash.hppinstead. Also remove the duplicated comments at the top of the file.
PatrickKa
force-pushed
the
test-error-handling-for-spi
branch
2 times, most recently
from
3c9064f to
72944b6
Compare
kamilchmela
force-pushed
the
test-error-handling-for-spi
branch
from
ee5999c to
a048173
Compare
kamilchmela
force-pushed
the
test-error-handling-for-spi
branch
4 times, most recently
from
afebffb to
e7de75c
Compare
PatrickKa
force-pushed
the
test-error-handling-for-spi
branch
4 times, most recently
from
1969100 to
54f7c8a
Compare
PatrickKa
approved these changes
Sep 23, 2024
PatrickKa
force-pushed
the
test-error-handling-for-spi
branch
from
191119d to
199a3f9
Compare
kamilchmela
force-pushed
the
test-error-handling-for-spi
branch
3 times, most recently
from
fe01b0d to
09d9d18
Compare
PatrickKa
force-pushed
the
test-error-handling-for-spi
branch
from
51e57a4 to
d5a484f
Compare
PatrickKa
force-pushed
the
test-error-handling-for-spi
branch
from
1ac2489 to
b202cf8
Compare
kamilchmela
force-pushed
the
test-error-handling-for-spi
branch
3 times, most recently
from
61c8644 to
4b579ed
Compare
PatrickKa
force-pushed
the
test-error-handling-for-spi
branch
4 times, most recently
from
8a7f774 to
94f23e7
Compare
This makes it easier to avoid cyclic dependencies.
The resume functions were not enough. We really needed the threads.
Add one for the SPI supervisor test.
PatrickKa
force-pushed
the
test-error-handling-for-spi
branch
from
4a87679 to
6193951
Compare
When building for sanitizers we should either use the debug or release flags. Useing `-O2` which is neither used for release nor debug builds is weird.
PatrickKa
force-pushed
the
test-error-handling-for-spi
branch
from
6193951 to
7902cfb
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #305