Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add initialize function for EPS sensors #252

Merged
merged 11 commits into from
Mar 5, 2024
Merged

Conversation

danielschloms
Copy link
Contributor

Description

This PR adds functionality to initialize the EPS ADCs for the COBC, including the necessary pin definitions.

Fixes #212

@danielschloms danielschloms linked an issue Feb 11, 2024 that may be closed by this pull request
@danielschloms
Copy link
Contributor Author

There are still 2 unresolved issues:

  • This cannot be tested until the COBC is available again.
  • The FRAM shares the same SPI, but uses a higher baudrate. This does not seem to be okay, as RODOS does not change the baudrate before transferring data, and the max. baudrate in the datasheet is 10 MHz (FRAM uses 12 MHz).

@codecov-commenter
Copy link

codecov-commenter commented Feb 11, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 87.15%. Comparing base (2759332) to head (68fe8ca).
Report is 11 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #252   +/-   ##
=======================================
  Coverage   87.15%   87.15%           
=======================================
  Files          18       18           
  Lines         514      514           
=======================================
  Hits          448      448           
  Misses         66       66           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@danielschloms danielschloms force-pushed the 212-initialize-eps-sensors branch from ded0d4c to 907b718 Compare February 11, 2024 15:25
Sts1CobcSw/Hal/IoNames.hpp Outdated Show resolved Hide resolved
Sts1CobcSw/Periphery/Eps.cpp Outdated Show resolved Hide resolved
Sts1CobcSw/Periphery/Eps.cpp Outdated Show resolved Hide resolved
Sts1CobcSw/Periphery/Eps.cpp Outdated Show resolved Hide resolved
Sts1CobcSw/Periphery/Eps.cpp Outdated Show resolved Hide resolved
Sts1CobcSw/Periphery/Eps.cpp Outdated Show resolved Hide resolved
Sts1CobcSw/Periphery/Eps.hpp Show resolved Hide resolved
Sts1CobcSw/Periphery/Eps.cpp Show resolved Hide resolved
Sts1CobcSw/Periphery/Eps.cpp Outdated Show resolved Hide resolved
Sts1CobcSw/Periphery/Eps.hpp Outdated Show resolved Hide resolved
@PatrickKa PatrickKa marked this pull request as ready for review March 5, 2024 19:19
@PatrickKa PatrickKa force-pushed the 212-initialize-eps-sensors branch from 0b6e687 to 4beb635 Compare March 5, 2024 19:39
@PatrickKa PatrickKa merged commit 254b6b5 into master Mar 5, 2024
6 checks passed
@PatrickKa PatrickKa deleted the 212-initialize-eps-sensors branch March 5, 2024 19:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add initialize function for EPS sensors
3 participants