Refactor RF function to read part info #251
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danielschloms
force-pushed
the
225-refactor-read-partinfo
branch
from
92acdb4 to
d9223e7
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #251 +/- ##
=======================================
Coverage 87.15% 87.15%
=======================================
Files 18 18
Lines 514 514
=======================================
Hits 448 448
Misses 66 66 ☔ View full report in Codecov by Sentry. |
This is done to adhere to #139
The function only returns the part of the part info that the application note calls "part number".
PatrickKa
approved these changes
Mar 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
All parts that are directly related to
ReadPartInfo()have been refactored (e.g. withSpan()or the new SPI initialization function). Magic numbers related to timings have been replaced in non-related parts out of convenience.Fixes #225