Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add low-level RF functions Initialize() and ReadPartInfo() #250

Merged
merged 5 commits into from
Feb 4, 2024
Merged

Conversation

danielschloms
Copy link
Contributor

@danielschloms danielschloms commented Feb 1, 2024

Description

The relevant code is taken from the mountain field test branch, but there are minimal changes to be able to compile it with the master branch as the base.

Fixes #188
Fixes #189

Copy link
Contributor

@PatrickKa PatrickKa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Make all tests pass
  • Remove unused headers from Rf.hpp
  • Right now, Rf.cpp includes headers that are already included in Rf.hpp. If that is still the case after finishing the first point, remove them, since this is the only exception to the rule "Directly include everything you use".
  • Why does RfNames.hpp exist? It provides nothing that is required for the public interfaces defined in Rf.hpp. Therefore, all of RfNames.hpp should be private, i.e., in the source file Rf.cpp.
  • Remove uciUart from Rf.test.cpp since it is never used. Don't forget to also remove the related includes that become unused and check target_link_libraries().

Tests/HardwareTests/Rf.test.cpp Outdated Show resolved Hide resolved
Sts1CobcSw/Periphery/Rf.hpp Outdated Show resolved Hide resolved
Sts1CobcSw/Periphery/Rf.hpp Outdated Show resolved Hide resolved
@PatrickKa PatrickKa changed the title Add low-level RF function to read part info Add low-level RF functions Initialize() and ReadPartInfo() Feb 3, 2024
@codecov-commenter
Copy link

codecov-commenter commented Feb 3, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (52ccd2b) 87.35% compared to head (cd20424) 87.35%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #250   +/-   ##
=======================================
  Coverage   87.35%   87.35%           
=======================================
  Files          18       18           
  Lines         514      514           
=======================================
  Hits          449      449           
  Misses         65       65           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@PatrickKa PatrickKa marked this pull request as ready for review February 4, 2024 11:38
@PatrickKa PatrickKa merged commit fcb8544 into master Feb 4, 2024
6 checks passed
@PatrickKa PatrickKa deleted the rf branch February 4, 2024 11:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add low-level RF initialize function Add low-level RF function to read part info
3 participants