Refactor EDU code #249
Merged
Refactor EDU code #249
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #249 +/- ##
==========================================
- Coverage 87.35% 87.15% -0.20%
==========================================
Files 18 18
Lines 514 514
==========================================
- Hits 449 448 -1
- Misses 65 66 +1 ☔ View full report in Codecov by Sentry. |
PatrickKa
force-pushed
the
refactor-edu
branch
from
95e2251 to
ee8f1f6
Compare
PatrickKa
force-pushed
the
refactor-edu
branch
from
0f1baf0 to
754d6b0
Compare
This is more convenient than having to provide a receive buffer in the user code all the time.
Also, replace `= 0U` with `= 0` every time `auto` is not used.
Now, all high-level EDU commands can be sent in the same way.
Also, rename Structs.ipp to Types.ipp
The data structs for the statuses now follow the same logic as those for the EDU commands: the ID is a static constexpr member and the name has a "Data" suffix.
This finishes the quest to only use non-blocking funtions for all EDU communication.
PatrickKa
force-pushed
the
refactor-edu
branch
from
754d6b0 to
95845e6
Compare
The normal ComputeCrc32() function changed to using the HW unit. The HW and SW methods are not identical though, so I switched to ComputeCrc32Sw() to get the behavior that the EDU expects right now.
This is the same number of times that the EDU will attempt to send data.
PatrickKa
force-pushed
the
refactor-edu
branch
from
95845e6 to
db8dc2d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Apart from only using the new HAL UART and removing the STOP command, I did some long overdue refactoring of the EDU code. I
GetStatus()andGetStatusCommunication,ErrorCodes,PRINTF()calls and commented out code.Fixes #215
Fixes #191
Fixes #248
Fixes #171
Fixes #235