Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix problems with COBC-EDU protocol #243

Merged
merged 3 commits into from
Dec 27, 2023
Merged

Fix problems with COBC-EDU protocol #243

merged 3 commits into from
Dec 27, 2023

Conversation

PatrickKa
Copy link
Contributor

Fixes #242

Both ProgramFinished and ResultsReady got 2 bytes longer because of the
queue-ID-to-start-time change.
@codecov-commenter
Copy link

codecov-commenter commented Dec 27, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (1f6186f) 87.35% compared to head (06c7d9a) 87.35%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #243   +/-   ##
=======================================
  Coverage   87.35%   87.35%           
=======================================
  Files          18       18           
  Lines         514      514           
=======================================
  Hits          449      449           
  Misses         65       65           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@PatrickKa PatrickKa merged commit 9cc32f4 into master Dec 27, 2023
6 checks passed
@PatrickKa PatrickKa deleted the fix-edu branch December 27, 2023 19:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

EDU commands tests yield timeout errors
2 participants