Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a DEBUG_PRINT() macro #234

Merged
merged 5 commits into from
Apr 28, 2024
Merged

Add a DEBUG_PRINT() macro #234

merged 5 commits into from
Apr 28, 2024

Conversation

jeromehue
Copy link
Contributor

@jeromehue jeromehue commented Dec 21, 2023

Description

Adds DEBUG_PRINT(), a macro that prints stuff via RODOS::PRINTF() if DEBUG is defined. Otherwise, it does nothing.

The test for DispatchCommand() is removed because it was a golden test that relied on the function actually printing what it does, which is not something the "real" DispatchCommand() would do. Also, the whole command parsing and handling has to be reworked anyway once we start implementing the real protocol that we will use in space.

Fixes #43

@codecov-commenter
Copy link

codecov-commenter commented Apr 28, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.54%. Comparing base (c8e128f) to head (7944925).

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #234      +/-   ##
==========================================
+ Coverage   88.36%   96.54%   +8.17%     
==========================================
  Files          20       14       -6     
  Lines         576      434     -142     
==========================================
- Hits          509      419      -90     
+ Misses         67       15      -52     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@PatrickKa PatrickKa changed the title Add a DebugPrint() macro Add a DEBUG_PRINT() macro Apr 28, 2024
@PatrickKa PatrickKa merged commit 8d3f1a8 into master Apr 28, 2024
6 checks passed
@PatrickKa PatrickKa deleted the debug-print branch April 28, 2024 14:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Define some DebugPrint() function
3 participants