-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update COBC-EDU protocol #169
Conversation
905c387
to
4d47dda
Compare
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #169 +/- ##
==========================================
- Coverage 81.81% 81.69% -0.13%
==========================================
Files 16 16
Lines 451 448 -3
==========================================
- Hits 369 366 -3
Misses 82 82 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I just realized that I made a mistake when I explained the issue to you 🙈. The queueId
should not just blindly be replaced with a timestamp. The queueId
should be removed from the QueueEntry
because the programId
together with the startTime
already uniquely identify different program runs. The commands to the EDU should then use this startTime
instead of the queueId
. It doesn't help that the EDU PDD calls our startTime
Timestamp
. So, basically queueId
should be replaced with startTime
, except when startTime
is already present, like in the QueueEntry
. Then queueId
should be removed.
c526eab
to
f7ce5b2
Compare
f7ce5b2
to
b62a297
Compare
Fixes #164