Add template parameter for endinanness in Serial.hpp #110
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PatrickKa
force-pushed
the
endianness
branch
from
ee7c04c to
197d3a5
Compare
PatrickKa
force-pushed
the
endianness
branch
2 times, most recently
from
713f75b to
a39e65b
Compare
Clang-tidy crashes now for some reason and I don't have the time or nerve right now to fix that. Setting CMAKE_CXX_STANDARD to 23 is not working properly. It adds the flag -std=c++23 but GCC only supports -std=c++2b. I added an ugly hack, because I also don't have the time or nerve right now to properly fix this.
GCC is fine with C++23. Only clang-tidy doesn't like it.
With etl::byteswap() we no longer need C++23 so we can activate clang-tidy again.
The endianness parameter was missing from all overloads of SerializeTo() and DeserializeFrom() for user defined types so "nothing" compiled.
PatrickKa
force-pushed
the
endianness
branch
from
a39e65b to
796bd15
Compare
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #110 +/- ##
==========================================
+ Coverage 77.20% 81.81% +4.61%
==========================================
Files 16 16
Lines 351 451 +100
==========================================
+ Hits 271 369 +98
- Misses 80 82 +2 ☔ View full report in Codecov by Sentry. |
PatrickKa
force-pushed
the
endianness
branch
from
7d8b407 to
0eaa90b
Compare
Also get rid of a warning.
PatrickKa
changed the title
Sometimes the upload to codecov.io fails. Apparently this is because of rate limits of the GitHub API. According to codecov issue #3954 (https://tinyurl.com/4enzfnpt) using an upload token should dramatically improve the issue but it cannot fix it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Also refactor Serial.hpp a bit.
Fixes #34